From: Simon Legner <Simon.Legner@gmail.com>
Date: Sun, 13 Mar 2016 20:22:42 +0000 (+0100)
Subject: Add title to changeset feeds
X-Git-Tag: live~3874
X-Git-Url: https://git.openstreetmap.org/rails.git/commitdiff_plain/5175ee68b00629daa03a788688b2cfe38ed8d3ee

Add title to changeset feeds

Fixes #1051
Closes #1180
---

diff --git a/app/helpers/changeset_helper.rb b/app/helpers/changeset_helper.rb
index 45c8be681..cc008aab7 100644
--- a/app/helpers/changeset_helper.rb
+++ b/app/helpers/changeset_helper.rb
@@ -31,4 +31,16 @@ module ChangesetHelper
         :user => changeset_user_link(changeset)
     end
   end
+
+  def changeset_list_title(params, user)
+    if params[:friends] && user
+      t "changeset.list.title_friend"
+    elsif params[:nearby] && user
+      t "changeset.list.title_nearby"
+    elsif params[:display_name]
+      t "changeset.list.title_user", :user => params[:display_name]
+    else
+      t "changeset.list.title"
+    end
+  end
 end
diff --git a/app/views/changeset/history.html.erb b/app/views/changeset/history.html.erb
index 77118b4b4..7f08a40b3 100644
--- a/app/views/changeset/history.html.erb
+++ b/app/views/changeset/history.html.erb
@@ -5,18 +5,11 @@
 <% end -%>
 
 <%
-   if params[:friends] and @user
-     set_title(t 'changeset.list.title_friend')
-     @heading = t 'changeset.list.title_friend'
-   elsif params[:nearby] and @user
-     set_title(t 'changeset.list.title_nearby')
-     @heading = t 'changeset.list.title_nearby'
-   elsif params[:display_name]
-     set_title(t 'changeset.list.title_user', :user => params[:display_name])
+   set_title(changeset_list_title(params, @user))
+   if params[:display_name]
      @heading = t('changeset.list.title_user', :user => link_to(params[:display_name], :controller => "user", :action => "view", :display_name => params[:display_name])).html_safe
    else
-     set_title(t 'changeset.list.title')
-     @heading = t 'changeset.list.title'
+     @heading = @title
    end
 %>
 
diff --git a/app/views/changeset/list.atom.builder b/app/views/changeset/list.atom.builder
index 619dc4a08..3e0cd9ec5 100644
--- a/app/views/changeset/list.atom.builder
+++ b/app/views/changeset/list.atom.builder
@@ -2,7 +2,7 @@ atom_feed(:language => I18n.locale, :schema_date => 2009,
           :id => url_for(params.merge({ :only_path => false })),
           :root_url => url_for(params.merge({ :action => :list, :format => nil, :only_path => false })),
           "xmlns:georss" => "http://www.georss.org/georss") do |feed|
-  feed.title @title
+  feed.title changeset_list_title(params, @user)
 
   feed.updated @edits.map {|e|  [e.created_at, e.closed_at].max }.max
   feed.icon "http://#{SERVER_URL}/favicon.ico"