From: Andy Allan <git@gravitystorm.co.uk>
Date: Thu, 2 Feb 2017 13:09:39 +0000 (+0000)
Subject: User factory for uniqueness tests
X-Git-Tag: live~3703^2~4
X-Git-Url: https://git.openstreetmap.org/rails.git/commitdiff_plain/584748fe0a9b20f7af5f9c6ebf127ec15b1350ad?hp=df6469c76b4d1f069a0831335a68e23ea1ebe0b1

User factory for uniqueness tests
---

diff --git a/test/models/user_test.rb b/test/models/user_test.rb
index 90499e1b1..3f66c5827 100644
--- a/test/models/user_test.rb
+++ b/test/models/user_test.rb
@@ -20,8 +20,9 @@ class UserTest < ActiveSupport::TestCase
   end
 
   def test_unique_email
+    existing_user = create(:user)
     new_user = User.new(
-      :email => users(:normal_user).email,
+      :email => existing_user.email,
       :status => "active",
       :pass_crypt => Digest::MD5.hexdigest("test"),
       :display_name => "new user",
@@ -33,11 +34,12 @@ class UserTest < ActiveSupport::TestCase
   end
 
   def test_unique_display_name
+    existing_user = create(:user)
     new_user = User.new(
       :email => "tester@openstreetmap.org",
       :status => "pending",
       :pass_crypt => Digest::MD5.hexdigest("test"),
-      :display_name => users(:normal_user).display_name,
+      :display_name => existing_user.display_name,
       :data_public => 1,
       :description => "desc"
     )