From: Tom Hughes <tom@compton.nu>
Date: Wed, 22 Dec 2021 15:26:23 +0000 (+0000)
Subject: Merge remote-tracking branch 'upstream/pull/3403'
X-Git-Tag: live~2719
X-Git-Url: https://git.openstreetmap.org/rails.git/commitdiff_plain/5a70476d38447d7b57d9bb96b55097d9d0873e3a?hp=88cf87c910365ce75629afd5b575f0c0817b2965

Merge remote-tracking branch 'upstream/pull/3403'
---

diff --git a/app/controllers/users_controller.rb b/app/controllers/users_controller.rb
index 4f05ece74..f7a82c08c 100644
--- a/app/controllers/users_controller.rb
+++ b/app/controllers/users_controller.rb
@@ -208,9 +208,9 @@ class UsersController < ApplicationController
   end
 
   ##
-  # delete a user, marking them as deleted and removing personal data
+  # destroy a user, marking them as deleted and removing personal data
   def destroy
-    @user.delete
+    @user.destroy
     redirect_to user_path(:display_name => params[:display_name])
   end
 
diff --git a/app/models/user.rb b/app/models/user.rb
index 8f02e35cf..1bb532152 100644
--- a/app/models/user.rb
+++ b/app/models/user.rb
@@ -242,8 +242,8 @@ class User < ApplicationRecord
   end
 
   ##
-  # delete a user - leave the account but purge most personal data
-  def delete
+  # destroy a user - leave the account but purge most personal data
+  def destroy
     avatar.purge_later
 
     self.display_name = "user_#{id}"
diff --git a/test/controllers/browse_controller_test.rb b/test/controllers/browse_controller_test.rb
index 135e49d3f..d9f4401bf 100644
--- a/test/controllers/browse_controller_test.rb
+++ b/test/controllers/browse_controller_test.rb
@@ -161,7 +161,7 @@ class BrowseControllerTest < ActionDispatch::IntegrationTest
     assert_select "div.note-comments ul li", :count => 2
     assert_select "div.details", /Resolved by #{user.display_name}/
 
-    user.delete
+    user.destroy
 
     reset!
 
diff --git a/test/models/user_test.rb b/test/models/user_test.rb
index c34b4b81f..76f520091 100644
--- a/test/models/user_test.rb
+++ b/test/models/user_test.rb
@@ -256,9 +256,9 @@ class UserTest < ActiveSupport::TestCase
     assert create(:moderator_user).has_role?("moderator")
   end
 
-  def test_delete
+  def test_destroy
     user = create(:user, :with_home_location, :description => "foo")
-    user.delete
+    user.destroy
     assert_equal "user_#{user.id}", user.display_name
     assert user.description.blank?
     assert_nil user.home_lat