From: Andy Allan <git@gravitystorm.co.uk>
Date: Thu, 9 Mar 2017 10:57:57 +0000 (+0000)
Subject: Use user factory for user_preference model tests.
X-Git-Tag: live~3547^2~6
X-Git-Url: https://git.openstreetmap.org/rails.git/commitdiff_plain/5e78831d5c6f3e37b9ebcbb3ca12654858349034

Use user factory for user_preference model tests.
---

diff --git a/test/models/user_preference_test.rb b/test/models/user_preference_test.rb
index 6f09d21c4..bceec0719 100644
--- a/test/models/user_preference_test.rb
+++ b/test/models/user_preference_test.rb
@@ -1,8 +1,6 @@
 require "test_helper"
 
 class UserPreferenceTest < ActiveSupport::TestCase
-  api_fixtures
-
   # Checks that you cannot add a new preference, that is a duplicate
   def test_add_duplicate_preference
     up = create(:user_preference)
@@ -19,7 +17,7 @@ class UserPreferenceTest < ActiveSupport::TestCase
     val = "v"
     (1..255).each do |i|
       up = UserPreference.new
-      up.user = users(:normal_user)
+      up.user = create(:user)
       up.k = key * i
       up.v = val * i
       assert up.valid?
@@ -35,7 +33,7 @@ class UserPreferenceTest < ActiveSupport::TestCase
     val = "v"
     [0, 256].each do |i|
       up = UserPreference.new
-      up.user = users(:normal_user)
+      up.user = create(:user)
       up.k = key * i
       up.v = val * i
       assert_equal false, up.valid?