From: Tom Hughes <tom@compton.nu>
Date: Sun, 9 Mar 2014 13:51:43 +0000 (+0000)
Subject: Disable query feature tool below z14
X-Git-Tag: live~4321^2~27
X-Git-Url: https://git.openstreetmap.org/rails.git/commitdiff_plain/606ac7610873859c48a42ccd39cfe58abb0d3870?hp=8a70e1c082b985c2ff1802d6ebff60783a6fc2b6

Disable query feature tool below z14
---

diff --git a/app/assets/javascripts/index/query.js b/app/assets/javascripts/index/query.js
index 096f7cca6..325d1d7f1 100644
--- a/app/assets/javascripts/index/query.js
+++ b/app/assets/javascripts/index/query.js
@@ -9,6 +9,8 @@ OSM.Query = function(map) {
     e.preventDefault();
     e.stopPropagation();
 
+    if (queryButton.hasClass("disabled")) return;
+
     if (queryButton.hasClass("active")) {
       disableQueryMode();
 
@@ -16,6 +18,18 @@ OSM.Query = function(map) {
     } else {
       enableQueryMode();
     }
+  }).on("disabled", function (e) {
+    if (queryButton.hasClass("active")) {
+      map.off("click", clickHandler);
+      $(map.getContainer()).removeClass("query-active").addClass("query-disabled");
+      $(this).tooltip("show");
+    }
+  }).on("enabled", function (e) {
+    if (queryButton.hasClass("active")) {
+      map.on("click", clickHandler);
+      $(map.getContainer()).removeClass("query-disabled").addClass("query-active");
+      $(this).tooltip("hide");
+    }
   });
 
   $("#sidebar_content")
@@ -230,7 +244,7 @@ OSM.Query = function(map) {
 
   function disableQueryMode() {
     if (marker) map.removeLayer(marker);
-    $(map.getContainer()).removeClass("query-active");
+    $(map.getContainer()).removeClass("query-active").removeClass("query-disabled");
     map.off("click", clickHandler);
     queryButton.removeClass("active");
   }
diff --git a/app/assets/javascripts/leaflet.query.js b/app/assets/javascripts/leaflet.query.js
index 3eab9054d..906487274 100644
--- a/app/assets/javascripts/leaflet.query.js
+++ b/app/assets/javascripts/leaflet.query.js
@@ -8,10 +8,29 @@ L.OSM.query = function (options) {
     var link = $('<a>')
       .attr('class', 'control-button')
       .attr('href', '#')
-      .attr('data-original-title', I18n.t('javascripts.site.queryfeature_tooltip'))
       .html('<span class="icon query"></span>')
       .appendTo($container);
 
+    map.on('zoomend', update);
+
+    update();
+
+    function update() {
+      var wasDisabled = link.hasClass('disabled'),
+        isDisabled = map.getZoom() < 14;
+      link
+        .toggleClass('disabled', isDisabled)
+        .attr('data-original-title', I18n.t(isDisabled ?
+          'javascripts.site.queryfeature_disabled_tooltip' :
+          'javascripts.site.queryfeature_tooltip'));
+
+      if (isDisabled && !wasDisabled) {
+        link.trigger('disabled');
+      } else if (wasDisabled && !isDisabled) {
+        link.trigger('enabled');
+      }
+    }
+
     return $container[0];
   };
 
diff --git a/app/assets/stylesheets/common.css.scss b/app/assets/stylesheets/common.css.scss
index 628096b9f..9e614f906 100644
--- a/app/assets/stylesheets/common.css.scss
+++ b/app/assets/stylesheets/common.css.scss
@@ -687,6 +687,10 @@ nav.secondary {
     &.query-active {
       cursor: help;
     }
+
+    &.query-disabled {
+      cursor: not-allowed;
+    }
   }
 
   #map-ui {
diff --git a/config/locales/en.yml b/config/locales/en.yml
index a4049f9e0..c4f757b76 100644
--- a/config/locales/en.yml
+++ b/config/locales/en.yml
@@ -2109,6 +2109,7 @@ en:
       map_notes_zoom_in_tooltip: Zoom in to see map notes
       map_data_zoom_in_tooltip: Zoom in to see map data
       queryfeature_tooltip: Query features
+      queryfeature_disabled_tooltip: Zoom in to query features
     notes:
       new:
         intro: "Spotted a mistake or something missing? Let other mappers know so we can fix it. Move the marker to the correct position and type a note to explain the problem. (Please don't enter personal information here.)"