From: Tom Hughes <tom@compton.nu>
Date: Wed, 9 Jun 2021 16:46:11 +0000 (+0100)
Subject: Merge remote-tracking branch 'upstream/pull/3216'
X-Git-Tag: live~1647
X-Git-Url: https://git.openstreetmap.org/rails.git/commitdiff_plain/616f3783df3f03dd0cab6f024d2f00bd5e1ce9ff?hp=7e5bbce23dcd72876c9947d232813efb48fe83eb

Merge remote-tracking branch 'upstream/pull/3216'
---

diff --git a/app/helpers/user_blocks_helper.rb b/app/helpers/user_blocks_helper.rb
index 73425edec..95b6cb600 100644
--- a/app/helpers/user_blocks_helper.rb
+++ b/app/helpers/user_blocks_helper.rb
@@ -26,9 +26,11 @@ module UserBlocksHelper
   end
 
   def block_duration_in_words(duration)
+    # Ensure the requested duration isn't negative, even by a millisecond
+    duration = 0 if duration.negative?
     parts = ActiveSupport::Duration.build(duration).parts
     if duration < 1.day
-      t("user_blocks.helper.block_duration.hours", :count => parts[:hours])
+      t("user_blocks.helper.block_duration.hours", :count => parts.fetch(:hours, 0))
     elsif duration < 1.week
       t("user_blocks.helper.block_duration.days", :count => parts[:days])
     elsif duration < 1.month
diff --git a/test/helpers/user_blocks_helper_test.rb b/test/helpers/user_blocks_helper_test.rb
index 16f83ec89..c4afa6c83 100644
--- a/test/helpers/user_blocks_helper_test.rb
+++ b/test/helpers/user_blocks_helper_test.rb
@@ -13,4 +13,24 @@ class UserBlocksHelperTest < ActionView::TestCase
     block = create(:user_block, :ends_at => Time.now.getutc + 1.hour)
     assert_match %r{^Ends in <span title=".*">about 1 hour</span>\.$}, block_status(block)
   end
+
+  def test_block_duration_in_words
+    words = block_duration_in_words(364.days)
+    assert_equal "11 months", words
+
+    words = block_duration_in_words(24.hours)
+    assert_equal "1 day", words
+
+    # Ensure that nil hours is not passed to i18n.t
+    words = block_duration_in_words(10.minutes)
+    assert_equal "0 hours", words
+
+    words = block_duration_in_words(0)
+    assert_equal "0 hours", words
+
+    # Ensure that (slightly) negative durations don't mess everything up
+    # This can happen on zero hour blocks when ends_at is a millisecond before created_at
+    words = block_duration_in_words(-0.001)
+    assert_equal "0 hours", words
+  end
 end