From: Tom Hughes <tom@compton.nu>
Date: Sat, 23 Mar 2013 18:38:49 +0000 (+0000)
Subject: Avoid reading nodes twice in WayController#full
X-Git-Tag: live~5068^2~13^2~4
X-Git-Url: https://git.openstreetmap.org/rails.git/commitdiff_plain/6300fa2a4fa717ef60f715a5303916b85d951c47

Avoid reading nodes twice in WayController#full
---

diff --git a/app/controllers/way_controller.rb b/app/controllers/way_controller.rb
index c3ffe3c0f..9f797d1d8 100644
--- a/app/controllers/way_controller.rb
+++ b/app/controllers/way_controller.rb
@@ -64,6 +64,7 @@ class WayController < ApplicationController
     way = Way.includes(:nodes => :node_tags).find(params[:id])
     
     if way.visible
+      visible_nodes = {}
       changeset_cache = {}
       user_display_name_cache = {}
 
@@ -71,9 +72,10 @@ class WayController < ApplicationController
       way.nodes.uniq.each do |node|
         if node.visible
           doc.root << node.to_xml_node(changeset_cache, user_display_name_cache)
+          visible_nodes[node.id] = node
         end
       end
-      doc.root << way.to_xml_node(nil, changeset_cache, user_display_name_cache)
+      doc.root << way.to_xml_node(visible_nodes, changeset_cache, user_display_name_cache)
       
       render :text => doc.to_s, :content_type => "text/xml"
     else