From: Andy Allan <git@gravitystorm.co.uk>
Date: Thu, 30 Mar 2017 12:57:07 +0000 (+0100)
Subject: For deleted nodes created via factories, make sure the most recent old_node is also... 
X-Git-Tag: live~3444
X-Git-Url: https://git.openstreetmap.org/rails.git/commitdiff_plain/66ae9a48a698b1f2b3f638117cbf64030ce90797

For deleted nodes created via factories, make sure the most recent old_node is also deleted
---

diff --git a/test/factories/node.rb b/test/factories/node.rb
index 1d8e244d7..cbebbb009 100644
--- a/test/factories/node.rb
+++ b/test/factories/node.rb
@@ -18,6 +18,13 @@ FactoryGirl.define do
         (1..node.version).each do |n|
           create(:old_node, :node_id => node.id, :version => n)
         end
+
+        # For deleted nodes, make sure the most recent old_node is also deleted.
+        if node.visible == false
+          latest = node.old_nodes.find_by(:version => node.version)
+          latest.visible = false
+          latest.save
+        end
       end
     end
   end