From: Tom Hughes <tom@compton.nu>
Date: Sun, 24 Jun 2007 16:00:46 +0000 (+0000)
Subject: Enhacements to the migration library code.
X-Git-Tag: live~8325
X-Git-Url: https://git.openstreetmap.org/rails.git/commitdiff_plain/69f364bb78eba1a3cb17d66fb61379fc9031fad3

Enhacements to the migration library code.
---

diff --git a/db/migrate/001_create_osm_db.rb b/db/migrate/001_create_osm_db.rb
index 3a98d6dc1..2c80dd8ad 100644
--- a/db/migrate/001_create_osm_db.rb
+++ b/db/migrate/001_create_osm_db.rb
@@ -2,9 +2,6 @@ require 'lib/migrate'
 
 class CreateOsmDb < ActiveRecord::Migration
   def self.up
-    myisam_table = { :id => false, :force => true, :options => "ENGINE=MyIsam DEFAULT CHARSET=utf8" }
-    innodb_table = { :id => false, :force => true, :options => "ENGINE=InnoDB DEFAULT CHARSET=utf8" }
-
     create_table "current_nodes", innodb_table do |t|
       t.column "id",        :bigint,   :limit => 64,                 :null => false
       t.column "latitude",  :double
diff --git a/lib/migrate.rb b/lib/migrate.rb
index 4cbabd6c0..c31e31538 100644
--- a/lib/migrate.rb
+++ b/lib/migrate.rb
@@ -7,17 +7,15 @@ module ActiveRecord
         execute "ALTER TABLE #{table_name} ADD PRIMARY KEY (#{quoted_column_names})"
       end
 
-      alias_method :old_add_column_options!, :add_column_options!
-
-      def add_column_options!(sql, options)
-        old_add_column_options!(sql, options)
-        sql << " #{options[:options]}"
+      def remove_primary_key(table_name)
+        execute "ALTER TABLE #{table_name} DROP PRIMARY KEY"
       end
 
       alias_method :old_options_include_default?, :options_include_default?
 
       def options_include_default?(options)
-        old_options_include_default?(options) && !(options[:options] =~ /AUTO_INCREMENT/i)
+        return false if options[:options] =~ /AUTO_INCREMENT/i
+        return old_options_include_default?(options)
       end
     end
 
@@ -27,11 +25,32 @@ module ActiveRecord
       def native_database_types
         types = old_native_database_types
         types[:bigint] = { :name => "bigint", :limit => 20 }
+        types[:double] = { :name => "double" }
         types
       end
+
+      def change_column(table_name, column_name, type, options = {})
+        unless options_include_default?(options)
+          options[:default] = select_one("SHOW COLUMNS FROM #{table_name} LIKE '#{column_name}'")["Default"]
+
+          unless type == :string or type == :text
+            options.delete(:default) if options[:default] = "";
+          end
+        end
+
+        change_column_sql = "ALTER TABLE #{table_name} CHANGE #{column_name} #{column_name} #{type_to_sql(type, options[:limit], options[:precision], options[:scale])}"
+        add_column_options!(change_column_sql, options)
+        change_column_sql << " #{options[:options]}"
+        execute(change_column_sql) 
+      end
+
+      def myisam_table
+        return { :id => false, :force => true, :options => "ENGINE=MyIsam" }
+      end
+
+      def innodb_table
+        return { :id => false, :force => true, :options => "ENGINE=InnoDB" }
+      end
     end
   end
 end
-
-myisam_table = { :id => false, :force => true, :options => "ENGINE=MyIsam" }
-innodb_table = { :id => false, :force => true, :options => "ENGINE=InnoDB" }