From: Andy Allan <git@gravitystorm.co.uk>
Date: Wed, 17 Jul 2019 09:52:02 +0000 (+0200)
Subject: Avoid using live models in old migrations
X-Git-Tag: live~2510^2~1
X-Git-Url: https://git.openstreetmap.org/rails.git/commitdiff_plain/6ebb21b66020ba845abd9fda408bb204d326e0de

Avoid using live models in old migrations

Instead, we define models in the migrations themselves. This ensures that
column names etc match the state of the database during the migration,
not the current live version of the model.
---

diff --git a/db/migrate/044_create_user_roles.rb b/db/migrate/044_create_user_roles.rb
index b62d8b890..0098a0086 100644
--- a/db/migrate/044_create_user_roles.rb
+++ b/db/migrate/044_create_user_roles.rb
@@ -1,6 +1,12 @@
 require "migrate"
 
 class CreateUserRoles < ActiveRecord::Migration[4.2]
+  class User < ActiveRecord::Base
+  end
+
+  class UserRole < ActiveRecord::Base
+  end
+
   def self.up
     create_enumeration :user_role_enum, %w[administrator moderator]
 
diff --git a/db/migrate/20120219161649_add_user_image_fingerprint.rb b/db/migrate/20120219161649_add_user_image_fingerprint.rb
index 1e6a19c21..c32d187b9 100644
--- a/db/migrate/20120219161649_add_user_image_fingerprint.rb
+++ b/db/migrate/20120219161649_add_user_image_fingerprint.rb
@@ -1,4 +1,7 @@
 class AddUserImageFingerprint < ActiveRecord::Migration[4.2]
+  class User < ActiveRecord::Base
+  end
+
   def up
     add_column :users, :image_fingerprint, :string, :null => true
 
diff --git a/db/migrate/20180204153242_tile_users.rb b/db/migrate/20180204153242_tile_users.rb
index cf20aed46..61dbcb4ea 100644
--- a/db/migrate/20180204153242_tile_users.rb
+++ b/db/migrate/20180204153242_tile_users.rb
@@ -1,4 +1,7 @@
 class TileUsers < ActiveRecord::Migration[5.1]
+  class User < ActiveRecord::Base
+  end
+
   def up
     add_column :users, :home_tile, :bigint
     add_index :users, [:home_tile], :name => "users_home_idx"