From: Tom Hughes <tom@compton.nu>
Date: Wed, 27 Mar 2019 18:49:01 +0000 (+0000)
Subject: erblint: avoid negated if conditions
X-Git-Tag: live~2644
X-Git-Url: https://git.openstreetmap.org/rails.git/commitdiff_plain/70f571fbcf40ccfcab5a1001fe8c6bb20860eb81?hp=7cd73546730cc83e475d3d647116e444894fdcc4;ds=sidebyside

erblint: avoid negated if conditions
---

diff --git a/.erb-lint.yml b/.erb-lint.yml
index 9c3d6b082..390d86ca6 100644
--- a/.erb-lint.yml
+++ b/.erb-lint.yml
@@ -37,8 +37,6 @@ linters:
         Enabled: false # TODO
       Style/SymbolProc:
         Enabled: false # TODO
-      Style/NegatedIf:
-        Enabled: false # TODO
       Style/ConditionalAssignment:
         Enabled: false # TODO
 exclude:
diff --git a/app/views/messages/_message_summary.html.erb b/app/views/messages/_message_summary.html.erb
index e69f43699..057a8980a 100644
--- a/app/views/messages/_message_summary.html.erb
+++ b/app/views/messages/_message_summary.html.erb
@@ -1,4 +1,4 @@
-<tr id="inbox-<%= message_summary.id %>" class="inbox-row<%= "-unread" if !message_summary.message_read? %>">
+<tr id="inbox-<%= message_summary.id %>" class="inbox-row<%= "-unread" unless message_summary.message_read? %>">
   <td class="inbox-sender"><%= link_to h(message_summary.sender.display_name), user_path(message_summary.sender) %></td>
   <td class="inbox-subject"><%= link_to h(message_summary.title), message_path(message_summary) %></td>
   <td class="inbox-sent"><%= l message_summary.sent_on, :format => :friendly %></td>