From: Tom Hughes <tom@compton.nu>
Date: Wed, 28 May 2014 08:55:34 +0000 (+0100)
Subject: Don't assume we know what ID the new block will have
X-Git-Tag: live~4335^2~1
X-Git-Url: https://git.openstreetmap.org/rails.git/commitdiff_plain/76ab4dc2f3414cb8f84e78f3925bf7196492e2c5

Don't assume we know what ID the new block will have
---

diff --git a/test/controllers/user_blocks_controller_test.rb b/test/controllers/user_blocks_controller_test.rb
index ffb5744ea..717f1167a 100644
--- a/test/controllers/user_blocks_controller_test.rb
+++ b/test/controllers/user_blocks_controller_test.rb
@@ -223,9 +223,10 @@ class UserBlocksControllerTest < ActionController::TestCase
         :user_block_period => "12",
         :user_block => { :needs_view => false, :reason => "Vandalism" }
     end
-    assert_redirected_to user_block_path(:id => 4)
+    id = UserBlock.order(:id).ids.last
+    assert_redirected_to user_block_path(:id => id)
     assert_equal "Created a block on user #{users(:unblocked_user).display_name}.", flash[:notice]
-    b = UserBlock.find(4)
+    b = UserBlock.find(id)
     assert_in_delta Time.now, b.created_at, 1
     assert_in_delta Time.now, b.updated_at, 1
     assert_in_delta Time.now + 12.hour, b.ends_at, 1