From: Tom Hughes <tom@compton.nu>
Date: Wed, 5 Sep 2012 22:05:07 +0000 (+0100)
Subject: Move piwik code to a static JS asset
X-Git-Tag: live~5403
X-Git-Url: https://git.openstreetmap.org/rails.git/commitdiff_plain/7c0055b5d71ed5be84998843cbc9b082d5ded2c5?ds=inline

Move piwik code to a static JS asset
---

diff --git a/app/assets/javascripts/application.js b/app/assets/javascripts/application.js
index 747c6d9af..f337415c6 100644
--- a/app/assets/javascripts/application.js
+++ b/app/assets/javascripts/application.js
@@ -6,6 +6,7 @@
 //= require openlayers
 //= require i18n/translations
 //= require globals
+//= require piwik
 //= require browse
 //= require export
 //= require map
diff --git a/app/assets/javascripts/globals.js.erb b/app/assets/javascripts/globals.js.erb
index 0f1b2b8ce..3c3bd92a7 100644
--- a/app/assets/javascripts/globals.js.erb
+++ b/app/assets/javascripts/globals.js.erb
@@ -1,4 +1,8 @@
 OSM = {
+<% if defined?(PIWIK_LOCATION) and defined?(PIWIK_SITE) %>
+  PIWIK_LOCATION:   <%= PIWIK_LOCATION.to_json %>,
+  PIWIK_SITE:       <%= PIWIK_SITE.to_json %>,
+<% end %>
   MAX_REQUEST_AREA: <%= MAX_REQUEST_AREA.to_json %>,
   SERVER_URL:       <%= SERVER_URL.to_json %>,
   API_VERSION:      <%= API_VERSION.to_json %>
diff --git a/app/assets/javascripts/piwik.js b/app/assets/javascripts/piwik.js
new file mode 100644
index 000000000..d0443ae6d
--- /dev/null
+++ b/app/assets/javascripts/piwik.js
@@ -0,0 +1,21 @@
+if (OSM.PIWIK_LOCATION && OSM.PIWIK_SITE) {
+  $(document).ready(function () {
+    var base = document.location.protocol + "//" + OSM.PIWIK_LOCATION + "/";
+
+    $.ajax({
+      url: base + "piwik.js",
+      dataType: "script",
+      cache: true,
+      success: function () {
+        var piwikTracker = Piwik.getTracker(base + "piwik.php", OSM.PIWIK_SITE);
+      
+        piwikTracker.trackPageView();
+        piwikTracker.enableLinkTracking();
+      
+        $("meta[name=piwik-goal]").each(function () {
+          piwikTracker.trackGoal($(this).attr("content"));
+        });
+      }
+    });
+  });
+}
diff --git a/app/views/layouts/_head.html.erb b/app/views/layouts/_head.html.erb
index 133a746a8..993544bae 100644
--- a/app/views/layouts/_head.html.erb
+++ b/app/views/layouts/_head.html.erb
@@ -11,6 +11,9 @@
   <%= tag("link", { :rel => "publisher", :href => "https://plus.google.com/111953119785824514010" }) %>
   <%= tag("link", { :rel => "search", :type => "application/opensearchdescription+xml", :title => "OpenStreetMap Search", :href => asset_path("osm.xml") }) %>
   <%= tag("meta", { :name => "description", :content => "OpenStreetMap is the free wiki world map." }) %>
+  <% if flash[:piwik_goal] -%>
+  <%= tag("meta", :name => "piwik-goal", :content => flash[:piwik_goal]) %>
+  <% end -%>  
   <%= style_rules %>
   <%= yield :head %>
   <%= csrf_meta_tag %>
diff --git a/app/views/layouts/_piwik.html.erb b/app/views/layouts/_piwik.html.erb
deleted file mode 100644
index 38db9692f..000000000
--- a/app/views/layouts/_piwik.html.erb
+++ /dev/null
@@ -1,14 +0,0 @@
-<script type="text/javascript">
-var _paq = _paq || [];
-(function(){ var u="<%= request.protocol %><%= PIWIK_LOCATION %>/";
-_paq.push(['setSiteId', <%= PIWIK_SITE %>]);
-_paq.push(['setTrackerUrl', u+'piwik.php']);
-_paq.push(['trackPageView']);
-_paq.push(['enableLinkTracking']);
-<% if flash[:piwik_goal] -%>
-_paq.push(['trackGoal', <%= flash[:piwik_goal] %>);
-<% end -%>
-var d=document, g=d.createElement('script'), s=d.getElementsByTagName('script')[0]; g.type='text/javascript'; g.defer=true; g.async=true; g.src=u+'piwik.js';
-s.parentNode.insertBefore(g,s); })();
-</script>
-<noscript><p><img src="<%= request.protocol %><%= PIWIK_LOCATION %>/piwik.php?idsite=<%= PIWIK_SITE %>" style="border:0" alt="" /></p></noscript>
diff --git a/app/views/layouts/site.html.erb b/app/views/layouts/site.html.erb
index e5c7e1bdd..b51191189 100644
--- a/app/views/layouts/site.html.erb
+++ b/app/views/layouts/site.html.erb
@@ -144,7 +144,7 @@
     </div>
 
     <% if defined?(PIWIK_LOCATION) and defined?(PIWIK_SITE) -%>
-    <%= render :partial => "layouts/piwik" %>
+    <noscript><p><img src="<%= request.protocol %><%= PIWIK_LOCATION %>/piwik.php?idsite=<%= PIWIK_SITE %>" style="border:0" alt="" /></p></noscript>
     <% end -%>
   </body>
 </html>