From: Tom Hughes <tom@compton.nu>
Date: Mon, 29 Oct 2018 19:14:55 +0000 (+0000)
Subject: Convert some model mixins to concerns
X-Git-Tag: live~2782
X-Git-Url: https://git.openstreetmap.org/rails.git/commitdiff_plain/82f3dc682302047781917e68c813dfe0e056fbda

Convert some model mixins to concerns
---

diff --git a/lib/geo_record.rb b/app/models/concerns/geo_record.rb
similarity index 89%
rename from lib/geo_record.rb
rename to app/models/concerns/geo_record.rb
index e02734ec9..06049c295 100644
--- a/lib/geo_record.rb
+++ b/app/models/concerns/geo_record.rb
@@ -1,6 +1,8 @@
 require "delegate"
 
 module GeoRecord
+  extend ActiveSupport::Concern
+
   # Ensure that when coordinates are printed that they are always in decimal degrees,
   # and not e.g. 4.0e-05
   # Unfortunately you can't extend Numeric classes directly (e.g. `Coord < Float`).
@@ -19,9 +21,9 @@ module GeoRecord
   # the database.
   SCALE = 10000000
 
-  def self.included(base)
-    base.scope :bbox, ->(bbox) { base.where(OSM.sql_for_area(bbox)) }
-    base.before_save :update_tile
+  included do
+    scope :bbox, ->(bbox) { where(OSM.sql_for_area(bbox)) }
+    before_save :update_tile
   end
 
   # Is this node within -90 >= latitude >= 90 and -180 >= longitude >= 180
diff --git a/lib/not_redactable.rb b/app/models/concerns/not_redactable.rb
similarity index 78%
rename from lib/not_redactable.rb
rename to app/models/concerns/not_redactable.rb
index 6a5773296..2d721530f 100644
--- a/lib/not_redactable.rb
+++ b/app/models/concerns/not_redactable.rb
@@ -1,6 +1,6 @@
-require "osm"
-
 module NotRedactable
+  extend ActiveSupport::Concern
+
   def redacted?
     false
   end
diff --git a/lib/object_metadata.rb b/app/models/concerns/object_metadata.rb
similarity index 97%
rename from lib/object_metadata.rb
rename to app/models/concerns/object_metadata.rb
index c765df526..dcfde889c 100644
--- a/lib/object_metadata.rb
+++ b/app/models/concerns/object_metadata.rb
@@ -1,4 +1,6 @@
 module ObjectMetadata
+  extend ActiveSupport::Concern
+
   def add_metadata_to_xml_node(el, osm, changeset_cache, user_display_name_cache)
     el["changeset"] = osm.changeset_id.to_s
     el["redacted"] = osm.redaction.id.to_s if osm.redacted?