From: Paweł Paprota <ppawel@fastmail.fm>
Date: Fri, 5 Oct 2012 18:23:40 +0000 (+0200)
Subject: Don't remove language prefixes from wikipedia tags
X-Git-Tag: live~5276
X-Git-Url: https://git.openstreetmap.org/rails.git/commitdiff_plain/8688edf992a909ca914834a00be58bbcd175f2e1

Don't remove language prefixes from wikipedia tags

Removing the language prefix from the displayed value of a wikipedia
tag is confusing, so don't do it. Fixes trac #4135.
---

diff --git a/app/helpers/browse_helper.rb b/app/helpers/browse_helper.rb
index ffc638cdf..ea17b8202 100644
--- a/app/helpers/browse_helper.rb
+++ b/app/helpers/browse_helper.rb
@@ -14,7 +14,7 @@ module BrowseHelper
       name = t 'printable_name.with_version', :id => name, :version => object.version.to_s
     end
 
-    # don't look at object tags if redacted, so as to avoid giving 
+    # don't look at object tags if redacted, so as to avoid giving
     # away redacted version tag information.
     unless object.redacted?
       if object.tags.include? "name:#{I18n.locale}"
@@ -63,7 +63,7 @@ module BrowseHelper
 
 private
 
-  ICON_TAGS = [ 
+  ICON_TAGS = [
     "aeroway", "amenity", "barrier", "building", "highway", "historic", "landuse",
     "leisure", "man_made", "natural", "railway", "shop", "tourism", "waterway"
   ]
@@ -99,8 +99,8 @@ private
       # from de to zh-classical
       if value =~ /^([a-z-]{2,12}):(.+)$/
         # Value is <lang>:<title> so split it up
+        # Note that value is always left as-is, see: https://trac.openstreetmap.org/ticket/4315
         lang  = $1
-        value = $2
       else
         # Value is <title> so default to English Wikipedia
         lang = 'en'