From: Tom Hughes <tom@compton.nu>
Date: Wed, 27 Mar 2019 19:14:16 +0000 (+0000)
Subject: erblint: avoid dynamic find_by methods
X-Git-Tag: live~2605
X-Git-Url: https://git.openstreetmap.org/rails.git/commitdiff_plain/89341ce266b085bbd15bc2907101f590adfea47e?ds=sidebyside

erblint: avoid dynamic find_by methods
---

diff --git a/.erb-lint.yml b/.erb-lint.yml
index d0ccb0c0d..3cca0301c 100644
--- a/.erb-lint.yml
+++ b/.erb-lint.yml
@@ -25,8 +25,6 @@ linters:
         Enabled: false
       Rails/OutputSafety:
         Enabled: false
-      Rails/DynamicFindBy:
-        Enabled: false # TODO
       Layout/LeadingBlankLines:
         Enabled: false # TODO
 exclude:
diff --git a/app/views/site/_potlatch.html.erb b/app/views/site/_potlatch.html.erb
index 745fb2012..3ebcf7fab 100644
--- a/app/views/site/_potlatch.html.erb
+++ b/app/views/site/_potlatch.html.erb
@@ -1,7 +1,7 @@
 <%= javascript_include_tag "edit/potlatch" %>
 
 <div id="map">
-  <% session[:token] = current_user.tokens.create.token unless session[:token] && UserToken.find_by_token(session[:token]) -%>
+  <% session[:token] = current_user.tokens.create.token unless session[:token] && UserToken.find_by(:token => session[:token]) -%>
   <% data = { :token => session[:token] } -%>
   <% data[:lat] = @lat if @lat -%>
   <% data[:lon] = @lon if @lon -%>
diff --git a/app/views/site/_potlatch2.html.erb b/app/views/site/_potlatch2.html.erb
index bb6d3f81e..11519c26e 100644
--- a/app/views/site/_potlatch2.html.erb
+++ b/app/views/site/_potlatch2.html.erb
@@ -1,7 +1,7 @@
 <%= javascript_include_tag "edit/potlatch2" %>
 
 <div id="map">
-  <% session[:token] = current_user.tokens.create.token unless session[:token] && UserToken.find_by_token(session[:token]) -%>
+  <% session[:token] = current_user.tokens.create.token unless session[:token] && UserToken.find_by(:token => session[:token]) -%>
   <% data = { :token => session[:token] } -%>
   <% data[:lat] = @lat if @lat -%>
   <% data[:lon] = @lon if @lon -%>