From: Tom Hughes <tom@compton.nu>
Date: Sat, 23 Mar 2019 12:01:05 +0000 (+0000)
Subject: Merge remote-tracking branch 'upstream/pull/2186'
X-Git-Tag: live~2763
X-Git-Url: https://git.openstreetmap.org/rails.git/commitdiff_plain/951564eed1c82ec1a435f4e4636db86d1b7604fc?hp=--cc

Merge remote-tracking branch 'upstream/pull/2186'
---

951564eed1c82ec1a435f4e4636db86d1b7604fc
diff --cc app/controllers/api_controller.rb
index 000000000,511748d8d..579af27cf
mode 000000,100644..100644
--- a/app/controllers/api_controller.rb
+++ b/app/controllers/api_controller.rb
@@@ -1,0 -1,79 +1,79 @@@
+ class ApiController < ApplicationController
+   skip_before_action :verify_authenticity_token
+ 
+   private
+ 
+   def authorize(realm = "Web Password", errormessage = "Couldn't authenticate you")
+     # make the current_user object from any auth sources we have
+     setup_user_auth
+ 
+     # handle authenticate pass/fail
+     unless current_user
+       # no auth, the user does not exist or the password was wrong
+       response.headers["WWW-Authenticate"] = "Basic realm=\"#{realm}\""
+       render :plain => errormessage, :status => :unauthorized
+       return false
+     end
+   end
+ 
+   def deny_access(_exception)
+     if current_token
+       set_locale
+       report_error t("oauth.permissions.missing"), :forbidden
+     elsif current_user
+       head :forbidden
+     else
+       realm = "Web Password"
+       errormessage = "Couldn't authenticate you"
+       response.headers["WWW-Authenticate"] = "Basic realm=\"#{realm}\""
+       render :plain => errormessage, :status => :unauthorized
+     end
+   end
+ 
+   def gpx_status
+     status = database_status
 -    status = :offline if status == :online && Settings.status == "gpx_offline"
++    status = "offline" if status == "online" && Settings.status == "gpx_offline"
+     status
+   end
+ 
+   ##
+   # sets up the current_user for use by other methods. this is mostly called
+   # from the authorize method, but can be called elsewhere if authorisation
+   # is optional.
+   def setup_user_auth
+     # try and setup using OAuth
+     unless Authenticator.new(self, [:token]).allow?
+       username, passwd = get_auth_data # parse from headers
+       # authenticate per-scheme
+       self.current_user = if username.nil?
+                             nil # no authentication provided - perhaps first connect (client should retry after 401)
+                           elsif username == "token"
+                             User.authenticate(:token => passwd) # preferred - random token for user from db, passed in basic auth
+                           else
+                             User.authenticate(:username => username, :password => passwd) # basic auth
+                           end
+     end
+ 
+     # have we identified the user?
+     if current_user
+       # check if the user has been banned
+       user_block = current_user.blocks.active.take
+       unless user_block.nil?
+         set_locale
+         if user_block.zero_hour?
+           report_error t("application.setup_user_auth.blocked_zero_hour"), :forbidden
+         else
+           report_error t("application.setup_user_auth.blocked"), :forbidden
+         end
+       end
+ 
+       # if the user hasn't seen the contributor terms then don't
+       # allow editing - they have to go to the web site and see
+       # (but can decline) the CTs to continue.
+       if !current_user.terms_seen && flash[:skip_terms].nil?
+         set_locale
+         report_error t("application.setup_user_auth.need_to_see_terms"), :forbidden
+       end
+     end
+   end
+ end