From: Tom Hughes <tom@compton.nu>
Date: Sun, 3 Apr 2011 15:00:06 +0000 (+0100)
Subject: Fixup the user map code to match existing code style
X-Git-Tag: live~6234^2~69
X-Git-Url: https://git.openstreetmap.org/rails.git/commitdiff_plain/9e6e6c2e231514e7b2eb96dacb0e5cc88fdd2abb

Fixup the user map code to match existing code style
---

diff --git a/app/views/user/_map.html.erb b/app/views/user/_map.html.erb
index 8947b05c1..6ab713995 100644
--- a/app/views/user/_map.html.erb
+++ b/app/views/user/_map.html.erb
@@ -35,51 +35,44 @@ end
 
     setMapCenter(centre, zoom);
 
-    <%
-    if marker :
-    %>
+    <% if marker %>
     marker = addMarkerToMap(
       new OpenLayers.LonLat(<%= mlon %>, <%= mlat %>)
-      <% if not setting_location : %>
-          , null, '<%=escape_javascript(render(:partial => "popup", :object => @user, :locals => { :type => "your location" })) %>'
+      <% if not setting_location %>
+        , null, '<%=escape_javascript(render(:partial => "popup", :object => @user, :locals => { :type => "your location" })) %>'
       <% end %>
     );
-    <%
-    end #endif
+    <% end %>
     
-    if setting_location :
-      # We're setting a location. Register for click events during init
-      %> map.events.register("click", map, setHome); <%
-    end
+    <% if setting_location %>
+    map.events.register("click", map, setHome);
+    <% end %>
     
-    if show_other_users :
-      friends = @user.friends.collect { |f| f.befriendee }.select { |f| !f.home_lat.nil? and !f.home_lon.nil? } 
-      nearest = @user.nearby - friends 
-    %>
-    var near_icon = OpenLayers.Marker.defaultIcon();
-    near_icon.url = OpenLayers.Util.getImagesLocation() + "marker-green.png";
-    <% nearest.each do |u| %>
-      addMarkerToMap(new OpenLayers.LonLat(
-        <%= u.home_lon %>, <%= u.home_lat %>), near_icon.clone(),
-        '<%= escape_javascript(render(:partial => "popup", :object => u, :locals => { :type => "nearby mapper" })) %>'
-      );
-    <% end  #next nearby user %>
-
-    var friend_icon = OpenLayers.Marker.defaultIcon();
-    friend_icon.url = OpenLayers.Util.getImagesLocation() + "marker-blue.png";
-    <% friends.each do |u| %>
-      addMarkerToMap(new OpenLayers.LonLat(
-        <%= u.home_lon %>, <%= u.home_lat %>), friend_icon.clone(),
-        '<%= escape_javascript(render(:partial => "popup", :object => u, :locals => { :type => "friend" })) %>'
-      );
-    <%
-      end  #next friend
-    end #endif
-    %>
+    <% if show_other_users %>
+      <% friends = @user.friends.collect { |f| f.befriendee }.select { |f| !f.home_lat.nil? and !f.home_lon.nil? } %>
+      <% nearest = @user.nearby - friends %>
+
+      var near_icon = OpenLayers.Marker.defaultIcon();
+      near_icon.url = OpenLayers.Util.getImagesLocation() + "marker-green.png";
+      <% nearest.each do |u| %>
+        addMarkerToMap(new OpenLayers.LonLat(
+          <%= u.home_lon %>, <%= u.home_lat %>), near_icon.clone(),
+          '<%= escape_javascript(render(:partial => "popup", :object => u, :locals => { :type => "nearby mapper" })) %>'
+        );
+      <% end %>
 
+      var friend_icon = OpenLayers.Marker.defaultIcon();
+      friend_icon.url = OpenLayers.Util.getImagesLocation() + "marker-blue.png";
+      <% friends.each do |u| %>
+        addMarkerToMap(new OpenLayers.LonLat(
+          <%= u.home_lon %>, <%= u.home_lat %>), friend_icon.clone(),
+          '<%= escape_javascript(render(:partial => "popup", :object => u, :locals => { :type => "friend" })) %>'
+        );
+      <% end %>
+    <% end %>
   }        
 
-  <% if setting_location : %>
+  <% if setting_location %>
   function setHome( e ) { 
     closeMapPopup();
 
@@ -97,7 +90,6 @@ end
       marker = addMarkerToMap(lonlat);
     }
   }
-  
   <% end %>
 
   window.onload = init;