From: Matt Amos <zerebubuth@gmail.com>
Date: Wed, 29 Oct 2008 15:33:23 +0000 (+0000)
Subject: Better error message and test for invalid UTF-8 sequences.
X-Git-Tag: live~7569^2~233
X-Git-Url: https://git.openstreetmap.org/rails.git/commitdiff_plain/9f3a4a5e0170a356b704b09220d533e0e17ccda0

Better error message and test for invalid UTF-8 sequences.
---

diff --git a/test/unit/message_test.rb b/test/unit/message_test.rb
index ea05b1307..3b83bf95a 100644
--- a/test/unit/message_test.rb
+++ b/test/unit/message_test.rb
@@ -62,7 +62,21 @@ class MessageTest < Test::Unit::TestCase
                          "\xe1\x82\x4a", # three-byte identifier, contination and (incorrectly) plain ASCII
                         ]
     invalid_sequences.each do |char|
-      assert_raise(ActiveRecord::RecordInvalid) { make_message(char, 1).save! } 
+      begin
+        # create a message and save to the database
+        msg = make_message(char, 1)
+        # if the save throws, thats fine and the test should pass, as we're
+        # only testing invalid sequences anyway.
+        msg.save! 
+
+        # get the saved message back and check that it is identical - i.e: 
+        # its OK to accept invalid UTF-8 as long as we return it unmodified.
+        db_msg = msg.class.find(msg.id)
+        assert_equal char, db_msg.title, "Database silently truncated message title"
+
+      rescue ActiveRecord::RecordInvalid
+        # because we only test invalid sequences it is OK to barf on them
+      end
     end
   end