From: Tom Hughes <tom@compton.nu>
Date: Wed, 27 Mar 2019 19:11:49 +0000 (+0000)
Subject: erblint: add rel=noopener to links that open in a new tab
X-Git-Tag: live~2679
X-Git-Url: https://git.openstreetmap.org/rails.git/commitdiff_plain/9f931ca1e3d6e1e1a1a2a354a78e84173a60df44?hp=1d97fd25b7248465ac4b7252c943fe9e91e55880

erblint: add rel=noopener to links that open in a new tab
---

diff --git a/.erb-lint.yml b/.erb-lint.yml
index 25811bccd..d0ccb0c0d 100644
--- a/.erb-lint.yml
+++ b/.erb-lint.yml
@@ -29,7 +29,5 @@ linters:
         Enabled: false # TODO
       Layout/LeadingBlankLines:
         Enabled: false # TODO
-      Rails/LinkToBlank:
-        Enabled: false # TODO
 exclude:
   - '**/vendor/**'
diff --git a/app/views/notifier/_message_body.html.erb b/app/views/notifier/_message_body.html.erb
index 29bd3e063..f8a4e2621 100644
--- a/app/views/notifier/_message_body.html.erb
+++ b/app/views/notifier/_message_body.html.erb
@@ -11,7 +11,7 @@
               :border => 0
             ),
             user_url(@author),
-            :target => "_blank"
+            :target => "_blank", :rel => "noopener"
           ) %>
     </td>
     <td style="text-align: left; vertical-align: top; padding-right: 10px; width: 100%">