From: Tom Hughes <tom@compton.nu>
Date: Thu, 9 Jan 2025 18:08:31 +0000 (+0000)
Subject: Merge remote-tracking branch 'upstream/pull/5487'
X-Git-Tag: live~435
X-Git-Url: https://git.openstreetmap.org/rails.git/commitdiff_plain/a6c6f26acbc9d5f62c4eddfb73bbbd5c5e03621a?hp=6c0366d2a2407184715ab97bc01410040b9612f5

Merge remote-tracking branch 'upstream/pull/5487'
---

diff --git a/app/controllers/diary_entries_controller.rb b/app/controllers/diary_entries_controller.rb
index 760c9a301..27099cd9c 100644
--- a/app/controllers/diary_entries_controller.rb
+++ b/app/controllers/diary_entries_controller.rb
@@ -123,7 +123,7 @@ class DiaryEntriesController < ApplicationController
       # Subscribe user to diary comments
       @diary_entry.subscriptions.create(:user => current_user)
 
-      redirect_to :action => "index", :display_name => current_user.display_name
+      redirect_to diary_entry_path(@diary_entry.user, @diary_entry)
     else
       render :action => "new"
     end
diff --git a/test/controllers/diary_entries_controller_test.rb b/test/controllers/diary_entries_controller_test.rb
index 91e2a58d9..a1c22fff8 100644
--- a/test/controllers/diary_entries_controller_test.rb
+++ b/test/controllers/diary_entries_controller_test.rb
@@ -159,8 +159,8 @@ class DiaryEntriesControllerTest < ActionDispatch::IntegrationTest
       post diary_entries_path(:diary_entry => { :title => "New Title", :body => "This is a new body for the diary entry", :latitude => "1.1",
                                                 :longitude => "2.2", :language_code => "en" })
     end
-    assert_redirected_to :action => :index, :display_name => user.display_name
     entry = DiaryEntry.last
+    assert_redirected_to diary_entry_path(user, entry)
     assert_equal user.id, entry.user_id
     assert_equal "New Title", entry.title
     assert_equal "This is a new body for the diary entry", entry.body
@@ -184,8 +184,8 @@ class DiaryEntriesControllerTest < ActionDispatch::IntegrationTest
       post diary_entries_path(:diary_entry => { :title => "New Title", :body => "This is a new body for the diary entry", :latitude => "1.1",
                                                 :longitude => "2.2", :language_code => "de" })
     end
-    assert_redirected_to :action => :index, :display_name => user.display_name
     entry = DiaryEntry.last
+    assert_redirected_to diary_entry_path(user, entry)
     assert_equal user.id, entry.user_id
     assert_equal "New Title", entry.title
     assert_equal "This is a new body for the diary entry", entry.body
@@ -211,8 +211,8 @@ class DiaryEntriesControllerTest < ActionDispatch::IntegrationTest
     assert_difference "DiaryEntry.count", 1 do
       post diary_entries_path(:diary_entry => { :title => spammy_title, :body => spammy_body, :language_code => "en" })
     end
-    assert_redirected_to :action => :index, :display_name => user.display_name
     entry = DiaryEntry.last
+    assert_redirected_to diary_entry_path(user, entry)
     assert_equal user.id, entry.user_id
     assert_equal spammy_title, entry.title
     assert_equal spammy_body, entry.body