From: Andy Allan <git@gravitystorm.co.uk>
Date: Mon, 10 Sep 2018 01:37:52 +0000 (+0800)
Subject: Use full url escaping when required in trace tests
X-Git-Tag: live~2920^2
X-Git-Url: https://git.openstreetmap.org/rails.git/commitdiff_plain/a8ecb1bf4ba160fc91f81f1d30d73b92f5abab52

Use full url escaping when required in trace tests
---

diff --git a/test/controllers/traces_controller_test.rb b/test/controllers/traces_controller_test.rb
index 605c47555..7cfc468b2 100644
--- a/test/controllers/traces_controller_test.rb
+++ b/test/controllers/traces_controller_test.rb
@@ -1032,8 +1032,8 @@ class TracesControllerTest < ActionController::TestCase
         assert_select "item", :count => traces.length do |items|
           traces.zip(items).each do |trace, item|
             assert_select item, "title", trace.name
-            assert_select item, "link", "http://test.host/user/#{trace.user.display_name.gsub(' ', '%20')}/traces/#{trace.id}"
-            assert_select item, "guid", "http://test.host/user/#{trace.user.display_name.gsub(' ', '%20')}/traces/#{trace.id}"
+            assert_select item, "link", "http://test.host/user/#{ERB::Util.u(trace.user.display_name)}/traces/#{trace.id}"
+            assert_select item, "guid", "http://test.host/user/#{ERB::Util.u(trace.user.display_name)}/traces/#{trace.id}"
             assert_select item, "description"
             # assert_select item, "dc:creator", trace.user.display_name
             assert_select item, "pubDate", trace.timestamp.rfc822