From: Andy Allan Date: Wed, 2 Aug 2023 15:57:26 +0000 (+0100) Subject: Merge pull request #4106 from tomhughes/diary-paging X-Git-Tag: live~678 X-Git-Url: https://git.openstreetmap.org/rails.git/commitdiff_plain/aceef47cd8f39928d27df43e2fdfee339ddafdc9?hp=f29ba01eb90b1db5937aeaee3b625e8840715396 Merge pull request #4106 from tomhughes/diary-paging Replace page numbers with ID based selection for diary indexes --- diff --git a/Gemfile.lock b/Gemfile.lock index d166be274..2cb6bf177 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -86,8 +86,8 @@ GEM autoprefixer-rails (10.4.13.0) execjs (~> 2) aws-eventstream (1.2.0) - aws-partitions (1.792.0) - aws-sdk-core (3.179.0) + aws-partitions (1.795.0) + aws-sdk-core (3.180.1) aws-eventstream (~> 1, >= 1.0.2) aws-partitions (~> 1, >= 1.651.0) aws-sigv4 (~> 1.5) @@ -300,11 +300,11 @@ GEM mini_magick (4.12.0) mini_mime (1.1.2) mini_portile2 (2.8.4) - minitest (5.18.1) + minitest (5.19.0) msgpack (1.7.2) multi_json (1.15.0) multi_xml (0.6.0) - net-imap (0.3.6) + net-imap (0.3.7) date net-protocol net-pop (0.1.2) @@ -374,9 +374,9 @@ GEM puma (5.6.6) nio4r (~> 2.0) quad_tile (1.0.1) - r2 (0.2.7) + r2 (0.2.8) racc (1.7.1) - rack (2.2.7) + rack (2.2.8) rack-cors (2.0.1) rack (>= 2.0.0) rack-openid (1.4.2) @@ -430,11 +430,11 @@ GEM regexp_parser (2.8.1) request_store (1.5.1) rack (>= 1.4) - rexml (3.2.5) + rexml (3.2.6) rinku (2.0.6) rotp (6.2.2) - rouge (4.1.2) - rubocop (1.54.2) + rouge (4.1.3) + rubocop (1.55.1) json (~> 2.3) language_server-protocol (>= 3.17.0) parallel (~> 1.10) @@ -442,7 +442,7 @@ GEM rainbow (>= 2.2.2, < 4.0) regexp_parser (>= 1.8, < 3.0) rexml (>= 3.2.5, < 4.0) - rubocop-ast (>= 1.28.0, < 2.0) + rubocop-ast (>= 1.28.1, < 2.0) ruby-progressbar (~> 1.7) unicode-display_width (>= 2.4.0, < 3.0) rubocop-ast (1.29.0) @@ -480,7 +480,7 @@ GEM sprockets-rails tilt secure_headers (6.5.0) - selenium-webdriver (4.10.0) + selenium-webdriver (4.11.0) rexml (~> 3.2, >= 3.2.5) rubyzip (>= 1.2.2, < 3.0) websocket (~> 1.0) @@ -526,12 +526,12 @@ GEM crack (>= 0.3.2) hashdiff (>= 0.4.0, < 2.0.0) websocket (1.2.9) - websocket-driver (0.7.5) + websocket-driver (0.7.6) websocket-extensions (>= 0.1.0) websocket-extensions (0.1.5) xpath (3.2.0) nokogiri (~> 1.8) - zeitwerk (2.6.9) + zeitwerk (2.6.10) PLATFORMS ruby diff --git a/app/abilities/ability.rb b/app/abilities/ability.rb index 5d196fa98..cdf28bd4f 100644 --- a/app/abilities/ability.rb +++ b/app/abilities/ability.rb @@ -56,7 +56,7 @@ class Ability can [:account, :go_public], User if user.moderator? - can [:hide, :hidecomment], DiaryEntry + can [:hide, :unhide, :hidecomment, :unhidecomment], DiaryEntry can [:index, :show, :resolve, :ignore, :reopen], Issue can :create, IssueComment can [:new, :create, :edit, :update, :destroy], Redaction diff --git a/app/assets/javascripts/index.js b/app/assets/javascripts/index.js index 38c498169..783c4da8d 100644 --- a/app/assets/javascripts/index.js +++ b/app/assets/javascripts/index.js @@ -192,11 +192,11 @@ $(document).ready(function () { }); if (Cookies.get("_osm_welcome") !== "hide") { - $(".welcome").addClass("visible"); + $(".welcome").removeAttr("hidden"); } $(".welcome .btn-close").on("click", function () { - $(".welcome").removeClass("visible"); + $(".welcome").hide(); Cookies.set("_osm_welcome", "hide", { secure: true, expires: expiry, path: "/", samesite: "lax" }); }); diff --git a/app/assets/javascripts/leaflet.share.js b/app/assets/javascripts/leaflet.share.js index b9c48f15a..7b1c995c2 100644 --- a/app/assets/javascripts/leaflet.share.js +++ b/app/assets/javascripts/leaflet.share.js @@ -66,7 +66,6 @@ L.OSM.share = function (options) { $("
") .attr("class", "share-tab") - .css("display", "block") .appendTo($form) .append($("") .attr("id", "long_input") @@ -75,6 +74,7 @@ L.OSM.share = function (options) { $("
") .attr("class", "share-tab") + .hide() .appendTo($form) .append($("") .attr("id", "short_input") @@ -83,6 +83,7 @@ L.OSM.share = function (options) { $("
") .attr("class", "share-tab") + .hide() .appendTo($form) .append( $("