From: mmd-osm <mmd.osm@gmail.com>
Date: Sat, 16 Dec 2017 12:32:04 +0000 (+0100)
Subject: Allow (un)subscribing discussions also when changeset still open
X-Git-Tag: live~3174^2~3
X-Git-Url: https://git.openstreetmap.org/rails.git/commitdiff_plain/b2a3955d936b448562db9981560135cf0303a0e0?hp=da52b3a778d26c8ab9497ab0aca1162e3880dfe0;ds=sidebyside

Allow (un)subscribing discussions also when changeset still open
Fixes #1627
---

diff --git a/app/controllers/changeset_controller.rb b/app/controllers/changeset_controller.rb
index 8fbbe1362..329cbd79c 100644
--- a/app/controllers/changeset_controller.rb
+++ b/app/controllers/changeset_controller.rb
@@ -357,7 +357,6 @@ class ChangesetController < ApplicationController
 
     # Find the changeset and check it is valid
     changeset = Changeset.find(id)
-    raise OSM::APIChangesetNotYetClosedError, changeset if changeset.is_open?
     raise OSM::APIChangesetAlreadySubscribedError, changeset if changeset.subscribers.exists?(current_user.id)
 
     # Add the subscriber
@@ -378,7 +377,6 @@ class ChangesetController < ApplicationController
 
     # Find the changeset and check it is valid
     changeset = Changeset.find(id)
-    raise OSM::APIChangesetNotYetClosedError, changeset if changeset.is_open?
     raise OSM::APIChangesetNotSubscribedError, changeset unless changeset.subscribers.exists?(current_user.id)
 
     # Remove the subscriber