From: Tom Hughes <tom@compton.nu>
Date: Tue, 31 Mar 2020 18:08:10 +0000 (+0100)
Subject: Fix new rubocop warnings
X-Git-Tag: live~2207
X-Git-Url: https://git.openstreetmap.org/rails.git/commitdiff_plain/b5c778b662730d5c26230c0ee1f1323ca5e0049c

Fix new rubocop warnings
---

diff --git a/app/controllers/api/user_preferences_controller.rb b/app/controllers/api/user_preferences_controller.rb
index 83e28bc4e..ddc5d7f43 100644
--- a/app/controllers/api/user_preferences_controller.rb
+++ b/app/controllers/api/user_preferences_controller.rb
@@ -25,9 +25,7 @@ module Api
 
     # update the entire set of preferences
     def update_all
-      old_preferences = current_user.preferences.each_with_object({}) do |preference, preferences|
-        preferences[preference.k] = preference
-      end
+      old_preferences = current_user.preferences.index_by(&:k)
 
       new_preferences = {}