From: Tom Hughes <tom@compton.nu>
Date: Fri, 19 Aug 2016 11:31:45 +0000 (+0100)
Subject: Improve code readability
X-Git-Tag: live~3821
X-Git-Url: https://git.openstreetmap.org/rails.git/commitdiff_plain/b72bc8bf30259f365511546c55f6e0568e850d44

Improve code readability
---

diff --git a/app/controllers/user_controller.rb b/app/controllers/user_controller.rb
index 9413ec6ed..d250cf21c 100644
--- a/app/controllers/user_controller.rb
+++ b/app/controllers/user_controller.rb
@@ -349,9 +349,13 @@ class UserController < ApplicationController
         @user.email = @user.new_email
         @user.new_email = nil
         @user.email_valid = true
-        changed = gravatar_enable(@user)
+        gravatar_enabled = gravatar_enable(@user)
         if @user.save
-          flash[:notice] = (t "user.confirm_email.success") + (changed ? " " + gravatar_status_message(@user) : "")
+          flash[:notice] = if gravatar_enabled
+                             t("user.confirm_email.success") + " " + gravatar_status_message(@user)
+                           else
+                             t("user.confirm_email.success")
+                           end
         else
           flash[:errors] = @user.errors
         end