From: Andy Allan <git@gravitystorm.co.uk>
Date: Wed, 20 Mar 2024 17:11:37 +0000 (+0000)
Subject: Merge pull request #4598 from AntonKhorev/fix-trace-description
X-Git-Tag: live~211
X-Git-Url: https://git.openstreetmap.org/rails.git/commitdiff_plain/bb3afad2c92da32dcf95ff3749ad4c6194df7ba8?hp=d115a1a7d7c7660696328ac3b10e159156d34489

Merge pull request #4598 from AntonKhorev/fix-trace-description

Fix trace feed image urls and local variable names
---

diff --git a/app/views/traces/_description.html.erb b/app/views/traces/_description.html.erb
index 5fea819da..538e7f1ec 100644
--- a/app/views/traces/_description.html.erb
+++ b/app/views/traces/_description.html.erb
@@ -1,6 +1,6 @@
-<%= image_tag trace_icon_path(description.user, description.id) %>
-<% if description.size -%>
-<%= t ".description_with_count", :count => description.size, :user => description.user.display_name %>
+<%= image_tag trace_icon_url(trace.user, trace) %>
+<% if trace.size -%>
+<%= t ".description_with_count", :count => trace.size, :user => trace.user.display_name %>
 <% else -%>
-<%= t ".description_without_count", :user => description.user.display_name %>
+<%= t ".description_without_count", :user => trace.user.display_name %>
 <% end -%>
diff --git a/app/views/traces/georss.rss.builder b/app/views/traces/georss.rss.builder
index 924ffb935..ad5bd45b2 100644
--- a/app/views/traces/georss.rss.builder
+++ b/app/views/traces/georss.rss.builder
@@ -25,7 +25,7 @@ xml.rss("version" => "2.0",
         xml.guid show_trace_url(trace.user, trace)
 
         xml.description do
-          xml.cdata! render(:partial => "description", :object => trace, :formats => [:html])
+          xml.cdata! render(:partial => "description", :object => trace, :as => "trace", :formats => [:html])
         end
 
         xml.dc :creator, trace.user.display_name
diff --git a/test/controllers/traces_controller_test.rb b/test/controllers/traces_controller_test.rb
index 2a6dc12dc..9a818786d 100644
--- a/test/controllers/traces_controller_test.rb
+++ b/test/controllers/traces_controller_test.rb
@@ -810,7 +810,11 @@ class TracesControllerTest < ActionDispatch::IntegrationTest
             assert_select item, "title", trace.name
             assert_select item, "link", "http://www.example.com/user/#{ERB::Util.u(trace.user.display_name)}/traces/#{trace.id}"
             assert_select item, "guid", "http://www.example.com/user/#{ERB::Util.u(trace.user.display_name)}/traces/#{trace.id}"
-            assert_select item, "description"
+            assert_select item, "description" do
+              assert_dom_encoded do
+                assert_select "img[src='#{trace_icon_url trace.user, trace}']"
+              end
+            end
             # assert_select item, "dc:creator", trace.user.display_name
             assert_select item, "pubDate", trace.timestamp.rfc822
           end