From: Tom Hughes <tom@compton.nu>
Date: Thu, 11 Oct 2018 17:51:45 +0000 (+0100)
Subject: Improve variable naming
X-Git-Tag: live~2814
X-Git-Url: https://git.openstreetmap.org/rails.git/commitdiff_plain/bdcc33ae7f93af9b62826cf9bd20c04d970566f4?ds=sidebyside

Improve variable naming
---

diff --git a/app/assets/javascripts/index/history.js b/app/assets/javascripts/index/history.js
index 3fcc2f790..51d854ad9 100644
--- a/app/assets/javascripts/index/history.js
+++ b/app/assets/javascripts/index/history.js
@@ -97,27 +97,24 @@ OSM.History = function(map) {
     $("[data-changeset]").each(function () {
       var changeset = $(this).data('changeset');
       if (changeset.bbox) {
-        var minProjection = map.project(L.latLng(changeset.bbox.minlat, changeset.bbox.minlon)),
-            maxProjection = map.project(L.latLng(changeset.bbox.maxlat, changeset.bbox.maxlon)),
-            xGap = maxProjection.x - minProjection.x,
-            yGap = minProjection.y - maxProjection.y,
-            minXGap = 40,  // Min width/height of changeset in pixels
-            minYGap = 40;
-
-        if (xGap < minXGap) {
-          minProjection.x -= ((minXGap - xGap) / 2);
-          maxProjection.x += ((minXGap - xGap) / 2);
+        var bottomLeft = map.project(L.latLng(changeset.bbox.minlat, changeset.bbox.minlon)),
+            topRight = map.project(L.latLng(changeset.bbox.maxlat, changeset.bbox.maxlon)),
+            width = topRight.x - bottomLeft.x,
+            height = bottomLeft.y - topRight.y,
+            minSize = 40;  // Min width/height of changeset in pixels
+
+        if (width < minSize) {
+          bottomLeft.x -= ((minSize - width) / 2);
+          topRight.x += ((minSize - width) / 2);
         }
 
-        if (yGap < minYGap) {
-          minProjection.y += ((minYGap - yGap) / 2);
-          maxProjection.y -= ((minYGap - yGap) / 2);
+        if (height < minSize) {
+          bottomLeft.y += ((minSize - height) / 2);
+          topRight.y -= ((minSize - height) / 2);
         }
 
-        var minUnProjection = map.unproject(minProjection),
-            maxUnProjection = map.unproject(maxProjection),
-            bounds = [minUnProjection,
-                      maxUnProjection];
+        var bounds = [map.unproject(bottomLeft),
+                      map.unproject(topRight)];
 
         changeset.bounds = L.latLngBounds(bounds);
         changesets.push(changeset);