From: Tom Hughes Date: Wed, 13 Mar 2024 18:05:48 +0000 (+0000) Subject: Merge remote-tracking branch 'upstream/pull/4566' X-Git-Tag: live~1246 X-Git-Url: https://git.openstreetmap.org/rails.git/commitdiff_plain/c91bd55222419f4c88c0c4a007a02580837f3dfa?hp=6524541975d35400c5ddb99df44e210bd63c7ac1 Merge remote-tracking branch 'upstream/pull/4566' --- diff --git a/Gemfile.lock b/Gemfile.lock index d57b4c5e5..b8d62ae73 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -95,7 +95,7 @@ GEM autoprefixer-rails (10.4.16.0) execjs (~> 2) aws-eventstream (1.3.0) - aws-partitions (1.895.0) + aws-partitions (1.896.0) aws-sdk-core (3.191.3) aws-eventstream (~> 1, >= 1.3.0) aws-partitions (~> 1, >= 1.651.0) @@ -123,8 +123,8 @@ GEM parser (>= 2.4) smart_properties bigdecimal (3.1.6) - binding_of_caller (1.0.0) - debug_inspector (>= 0.0.1) + binding_of_caller (1.0.1) + debug_inspector (>= 1.2.0) bootsnap (1.18.3) msgpack (~> 1.2) bootstrap (5.3.2) @@ -258,7 +258,7 @@ GEM highline (3.0.1) htmlentities (4.3.4) http_accept_language (2.1.1) - i18n (1.14.1) + i18n (1.14.4) concurrent-ruby (~> 1.0) i18n-js (3.9.2) i18n (>= 0.6.6) @@ -289,7 +289,7 @@ GEM image_size (3.4.0) in_threads (1.6.0) io-console (0.7.2) - irb (1.11.2) + irb (1.12.0) rdoc reline (>= 0.4.2) jbuilder (2.11.5) @@ -308,7 +308,7 @@ GEM rexml language_server-protocol (3.17.0.3) libv8-node (18.16.0.0) - libxml-ruby (5.0.2) + libxml-ruby (5.0.3) listen (3.9.0) rb-fsevent (~> 0.10, >= 0.10.3) rb-inotify (~> 0.9, >= 0.9.10) @@ -485,7 +485,7 @@ GEM rouge (4.2.0) rtlcss (0.2.1) mini_racer (>= 0.6.3) - rubocop (1.61.0) + rubocop (1.62.1) json (~> 2.3) language_server-protocol (>= 3.17.0) parallel (~> 1.10) @@ -493,18 +493,18 @@ GEM rainbow (>= 2.2.2, < 4.0) regexp_parser (>= 1.8, < 3.0) rexml (>= 3.2.5, < 4.0) - rubocop-ast (>= 1.30.0, < 2.0) + rubocop-ast (>= 1.31.1, < 2.0) ruby-progressbar (~> 1.7) unicode-display_width (>= 2.4.0, < 3.0) - rubocop-ast (1.31.1) + rubocop-ast (1.31.2) parser (>= 3.3.0.4) rubocop-capybara (2.20.0) rubocop (~> 1.41) rubocop-factory_bot (2.25.1) rubocop (~> 1.41) - rubocop-minitest (0.34.5) - rubocop (>= 1.39, < 2.0) - rubocop-ast (>= 1.30.0, < 2.0) + rubocop-minitest (0.35.0) + rubocop (>= 1.61, < 2.0) + rubocop-ast (>= 1.31.1, < 2.0) rubocop-performance (1.20.2) rubocop (>= 1.48.1, < 2.0) rubocop-ast (>= 1.30.0, < 2.0) @@ -554,7 +554,7 @@ GEM activesupport (>= 5.2) sprockets (>= 3.0.0) stringio (3.1.0) - strong_migrations (1.7.0) + strong_migrations (1.8.0) activerecord (>= 5.2) terminal-table (3.0.2) unicode-display_width (>= 1.1.1, < 3) diff --git a/app/abilities/api_ability.rb b/app/abilities/api_ability.rb index 0eae46f82..8ee280b3a 100644 --- a/app/abilities/api_ability.rb +++ b/app/abilities/api_ability.rb @@ -17,9 +17,7 @@ class ApiAbility can [:index, :show], Node can [:index, :show, :full, :ways_for_node], Way can [:index, :show, :full, :relations_for_node, :relations_for_way, :relations_for_relation], Relation - can [:history, :version], OldNode - can [:history, :version], OldWay - can [:history, :version], OldRelation + can [:history, :show], [OldNode, OldWay, OldRelation] can [:show], UserBlock if user&.active? diff --git a/app/controllers/api/old_controller.rb b/app/controllers/api/old_controller.rb index ceed10978..7c9c32e63 100644 --- a/app/controllers/api/old_controller.rb +++ b/app/controllers/api/old_controller.rb @@ -7,7 +7,7 @@ module Api before_action :check_api_readable before_action :check_api_writable, :only => [:redact] - before_action :setup_user_auth, :only => [:history, :version] + before_action :setup_user_auth, :only => [:history, :show] before_action :authorize, :only => [:redact] authorize_resource @@ -38,7 +38,7 @@ module Api end end - def version + def show if @old_element.redacted? && !show_redactions? head :forbidden diff --git a/app/models/user.rb b/app/models/user.rb index 7ed7c249f..45ecbcc1b 100644 --- a/app/models/user.rb +++ b/app/models/user.rb @@ -360,9 +360,9 @@ class User < ApplicationRecord diary_comment_score = diary_comments.visible.inject(0) { |acc, elem| acc + elem.body.spam_score } score = description.spam_score / 4.0 - score += diary_entries.where("created_at > ?", 1.day.ago).count * 10 - score += diary_entry_score / diary_entries.length unless diary_entries.empty? - score += diary_comment_score / diary_comments.length unless diary_comments.empty? + score += diary_entries.visible.where("created_at > ?", 1.day.ago).count * 10 + score += diary_entry_score / diary_entries.visible.length unless diary_entries.visible.empty? + score += diary_comment_score / diary_comments.visible.length unless diary_comments.visible.empty? score -= changeset_score score -= trace_score diff --git a/app/views/api/old_nodes/version.json.jbuilder b/app/views/api/old_nodes/show.json.jbuilder similarity index 100% rename from app/views/api/old_nodes/version.json.jbuilder rename to app/views/api/old_nodes/show.json.jbuilder diff --git a/app/views/api/old_nodes/version.xml.builder b/app/views/api/old_nodes/show.xml.builder similarity index 100% rename from app/views/api/old_nodes/version.xml.builder rename to app/views/api/old_nodes/show.xml.builder diff --git a/app/views/api/old_relations/version.json.jbuilder b/app/views/api/old_relations/show.json.jbuilder similarity index 100% rename from app/views/api/old_relations/version.json.jbuilder rename to app/views/api/old_relations/show.json.jbuilder diff --git a/app/views/api/old_relations/version.xml.builder b/app/views/api/old_relations/show.xml.builder similarity index 100% rename from app/views/api/old_relations/version.xml.builder rename to app/views/api/old_relations/show.xml.builder diff --git a/app/views/api/old_ways/version.json.jbuilder b/app/views/api/old_ways/show.json.jbuilder similarity index 100% rename from app/views/api/old_ways/version.json.jbuilder rename to app/views/api/old_ways/show.json.jbuilder diff --git a/app/views/api/old_ways/version.xml.builder b/app/views/api/old_ways/show.xml.builder similarity index 100% rename from app/views/api/old_ways/version.xml.builder rename to app/views/api/old_ways/show.xml.builder diff --git a/app/views/browse/_version_actions.erb b/app/views/browse/_version_actions.erb index 46bfd0dc2..3d4e4be13 100644 --- a/app/views/browse/_version_actions.erb +++ b/app/views/browse/_version_actions.erb @@ -2,7 +2,7 @@ <%= link_to t("browse.view_details"), :controller => :browse, :action => @type %> <% if !@feature.redacted? %> · - <%= link_to t("browse.download_xml"), :controller => "api/old_#{@type.pluralize}", :action => :version %> + <%= link_to t("browse.download_xml"), :controller => "api/old_#{@type.pluralize}", :action => :show %> <% elsif current_user&.moderator? %> · <% if !params[:show_redactions] %> diff --git a/app/views/changesets/show.html.erb b/app/views/changesets/show.html.erb index 57a3fdb56..fdaf7654c 100644 --- a/app/views/changesets/show.html.erb +++ b/app/views/changesets/show.html.erb @@ -80,11 +80,11 @@ <%= render :partial => "paging_nav", :locals => { :type => "way", :pages => @way_pages } %> <% end %> @@ -93,11 +93,11 @@ <%= render :partial => "paging_nav", :locals => { :type => "relation", :pages => @relation_pages } %> <% end %> @@ -106,11 +106,11 @@ <%= render :partial => "paging_nav", :locals => { :type => "node", :pages => @node_pages } %> <% end %> diff --git a/app/views/layouts/map.html.erb b/app/views/layouts/map.html.erb index f6a7473a4..9c1eb7020 100644 --- a/app/views/layouts/map.html.erb +++ b/app/views/layouts/map.html.erb @@ -44,10 +44,9 @@