From: Shaun McDonald <shaun@shaunmcdonald.me.uk>
Date: Thu, 23 Apr 2009 21:03:59 +0000 (+0000)
Subject: The render method needs to be last, otherwise the error header won't get set. Needs... 
X-Git-Tag: live~7495
X-Git-Url: https://git.openstreetmap.org/rails.git/commitdiff_plain/e3ae690a006f4bf23eaedcd9817d0750ceeebc55

The render method needs to be last, otherwise the error header won't get set. Needs tests.
---

diff --git a/app/controllers/application.rb b/app/controllers/application.rb
index bfd2e9c54..3d8a02810 100644
--- a/app/controllers/application.rb
+++ b/app/controllers/application.rb
@@ -96,9 +96,9 @@ class ApplicationController < ActionController::Base
   #  phrase from that, we can also put the error message into the status
   #  message. For now, rails won't let us)
   def report_error(message)
-    render :text => message, :status => :bad_request
     # Todo: some sort of escaping of problem characters in the message
     response.headers['Error'] = message
+    render :text => message, :status => :bad_request
   end
 
 private