From: Dan Stowell <danstowell@users.sourceforge.net>
Date: Sun, 9 Aug 2015 18:29:37 +0000 (+0100)
Subject: tidier code
X-Git-Tag: live~3604^2~4^2~3
X-Git-Url: https://git.openstreetmap.org/rails.git/commitdiff_plain/e5b5faad7228253147bc489402ef7640b071eaaf?hp=a2cf9b5b9f568c614ad8bbf8a477326b01cefb57

tidier code
---

diff --git a/app/assets/javascripts/index.js b/app/assets/javascripts/index.js
index 6f081c617..496ab29b9 100644
--- a/app/assets/javascripts/index.js
+++ b/app/assets/javascripts/index.js
@@ -76,31 +76,38 @@ $(document).ready(function () {
 
   var params = OSM.mapParams();
 
-  // TODO consider using a separate js file for the context menu additions
+  // a separate js file would be nice for the context menu additions; however not clear if context menu can be added outside of context of map obj constructor
   var context_describe = function(e){
-    var precision = OSM.zoomPrecision(map.getZoom());
-    OSM.router.route("/search?query=" + encodeURIComponent(
-      e.latlng.lat.toFixed(precision) + "," + e.latlng.lng.toFixed(precision)
-    ));
+    var precision = OSM.zoomPrecision(map.getZoom()),
+      latlng = e.latlng.wrap(),
+      lat = latlng.lat.toFixed(precision),
+      lng = latlng.lng.toFixed(precision);
+    OSM.router.route("/search?query=" + encodeURIComponent(lat + "," + lng));
   };
 
   var context_directionsfrom = function(e){
-    var precision = OSM.zoomPrecision(map.getZoom());
+    var precision = OSM.zoomPrecision(map.getZoom()),
+      latlng = e.latlng.wrap(),
+      lat = latlng.lat.toFixed(precision),
+      lng = latlng.lng.toFixed(precision);
     OSM.router.route("/directions?" + querystring.stringify({
-      route: e.latlng.lat.toFixed(precision) + ',' + e.latlng.lng.toFixed(precision) + ';' + $('#route_to').val()
+      route: lat + ',' + lng + ';' + $('#route_to').val()
     }));
   }
 
   var context_directionsto = function(e){
-    var precision = OSM.zoomPrecision(map.getZoom());
+    var precision = OSM.zoomPrecision(map.getZoom()),
+      latlng = e.latlng.wrap(),
+      lat = latlng.lat.toFixed(precision),
+      lng = latlng.lng.toFixed(precision);
     OSM.router.route("/directions?" + querystring.stringify({
-      route: $('#route_from').val() + ';' + e.latlng.lat.toFixed(precision) + ',' + e.latlng.lng.toFixed(precision)
+      route: $('#route_from').val() + ';' + lat + ',' + lng
     }));
   }
 
   var context_addnote = function(e){
     // I'd like this, instead of panning, to pass a query parameter about where to place the marker
-    map.panTo(e.latlng, {animate: false});
+    map.panTo(e.latlng.wrap(), {animate: false});
     OSM.router.route('/note/new');
   }
 
@@ -113,7 +120,6 @@ $(document).ready(function () {
       latlng = e.latlng.wrap(),
       lat = latlng.lat.toFixed(precision),
       lng = latlng.lng.toFixed(precision);
-
     OSM.router.route("/query?lat=" + lat + "&lon=" + lng);
   }