From: Andy Allan <git@gravitystorm.co.uk>
Date: Thu, 17 Aug 2017 18:03:50 +0000 (+0100)
Subject: Add failing test demonstrating tag duplication when updating traces via the API.
X-Git-Tag: live~3291^2~2
X-Git-Url: https://git.openstreetmap.org/rails.git/commitdiff_plain/e9324ad6818cfec0578a8fa4dac0b2724a1445f1

Add failing test demonstrating tag duplication when updating traces via the API.
---

diff --git a/test/controllers/trace_controller_test.rb b/test/controllers/trace_controller_test.rb
index 4610852fb..b635f3e57 100644
--- a/test/controllers/trace_controller_test.rb
+++ b/test/controllers/trace_controller_test.rb
@@ -931,6 +931,20 @@ class TraceControllerTest < ActionController::TestCase
     assert_equal nt.visibility, t.visibility
   end
 
+  # Test that updating a trace doesn't duplicate the tags
+  def test_api_update_tags
+    tracetag = create(:tracetag)
+    trace = tracetag.trace
+    basic_authorization trace.user.display_name, "test"
+
+    content trace.to_xml
+    put :api_update, :params => { :id => trace.id }
+    assert_response :success
+
+    updated = Trace.find(trace.id)
+    assert_equal trace.tags, updated.tags
+  end
+
   # Check deleting a trace through the api
   def test_api_delete
     public_trace_file = create(:trace, :visibility => "public")