From: Gabriel Ebner <gabriel@svn.openstreetmap.org>
Date: Mon, 12 May 2008 21:10:38 +0000 (+0000)
Subject: api06: s/delete_with_relations_and_history/delete_with_history/g
X-Git-Tag: live~7557^2~342
X-Git-Url: https://git.openstreetmap.org/rails.git/commitdiff_plain/ea1961e3ce54432e15a2468fb7b711937fd1517a?ds=sidebyside

api06: s/delete_with_relations_and_history/delete_with_history/g
---

diff --git a/app/controllers/changeset_controller.rb b/app/controllers/changeset_controller.rb
index 9994a6b1e..db3a26295 100644
--- a/app/controllers/changeset_controller.rb
+++ b/app/controllers/changeset_controller.rb
@@ -167,7 +167,7 @@ class ChangesetController < ApplicationController
       doc.find('//osm/delete/way').each do |nd|
 	elem = XML::Node.new 'way'
 	way = Way.find(nd['id'])
-	way.delete_with_relations_and_history(@user)
+	way.delete_with_history(@user)
 	elem['old_id'] = elem['new_id'] = way.id.to_s
 	elem['new_version'] = way.version.to_s
 	root << elem
diff --git a/app/controllers/way_controller.rb b/app/controllers/way_controller.rb
index b22d35d0b..21f2ea765 100644
--- a/app/controllers/way_controller.rb
+++ b/app/controllers/way_controller.rb
@@ -70,7 +70,7 @@ class WayController < ApplicationController
   def delete
     begin
       way = Way.find(params[:id])
-      way.delete_with_relations_and_history(@user)
+      way.delete_with_history(@user)
 
       # if we get here, all is fine, otherwise something will catch below.  
       render :nothing => true
diff --git a/app/models/way.rb b/app/models/way.rb
index a6192e2d7..ea027fb47 100644
--- a/app/models/way.rb
+++ b/app/models/way.rb
@@ -221,8 +221,7 @@ class Way < ActiveRecord::Base
     return true
   end
 
-  # Delete the way and it's relations, but don't really delete it - set its visibility to false and update the history etc to maintain wiki-like functionality.
-  def delete_with_relations_and_history(user)
+  def delete_with_history(user)
     if self.visible
 	  # FIXME
 	  # this should actually delete the relations,
@@ -246,6 +245,8 @@ class Way < ActiveRecord::Base
   end
 
   # delete a way and it's nodes that aren't part of other ways, with history
+
+  # FIXME: merge the potlatch code to delete the relations
   def delete_with_relations_and_nodes_and_history(user)
     
     node_ids = self.nodes.collect {|node| node.id }
@@ -266,7 +267,7 @@ class Way < ActiveRecord::Base
     
     self.user_id = user.id
 
-    self.delete_with_relations_and_history(user)
+    self.delete_with_history(user)
 
   end
 end