From: Tom Hughes Date: Wed, 6 Sep 2023 17:42:29 +0000 (+0100) Subject: Merge remote-tracking branch 'upstream/pull/4225' X-Git-Tag: live~630 X-Git-Url: https://git.openstreetmap.org/rails.git/commitdiff_plain/f138055849e5b09cd94797c3e1705c6357d6b93b?hp=7e6de66444437699124871e203cb72b6e737f546 Merge remote-tracking branch 'upstream/pull/4225' --- diff --git a/.github/workflows/docker.yml b/.github/workflows/docker.yml index 74d03b31c..df617d4fb 100644 --- a/.github/workflows/docker.yml +++ b/.github/workflows/docker.yml @@ -11,7 +11,7 @@ jobs: runs-on: ubuntu-22.04 steps: - name: Checkout source - uses: actions/checkout@v3 + uses: actions/checkout@v4 - name: Poke config run: | cp config/example.storage.yml config/storage.yml diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index e762df445..685937b03 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -14,7 +14,7 @@ jobs: runs-on: ubuntu-22.04 steps: - name: Check out code - uses: actions/checkout@v3 + uses: actions/checkout@v4 - name: Setup ruby uses: ruby/setup-ruby@v1 with: @@ -27,7 +27,7 @@ jobs: runs-on: ubuntu-22.04 steps: - name: Check out code - uses: actions/checkout@v3 + uses: actions/checkout@v4 - name: Setup ruby uses: ruby/setup-ruby@v1 with: @@ -40,7 +40,7 @@ jobs: runs-on: ubuntu-22.04 steps: - name: Check out code - uses: actions/checkout@v3 + uses: actions/checkout@v4 - name: Setup ruby uses: ruby/setup-ruby@v1 with: @@ -64,7 +64,7 @@ jobs: runs-on: ubuntu-22.04 steps: - name: Check out code - uses: actions/checkout@v3 + uses: actions/checkout@v4 - name: Setup ruby uses: ruby/setup-ruby@v1 with: diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 1d5c947e0..2b9dae62e 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -18,7 +18,7 @@ jobs: OPENSTREETMAP_MEMCACHE_SERVERS: 127.0.0.1 steps: - name: Checkout source - uses: actions/checkout@v3 + uses: actions/checkout@v4 - name: Setup ruby uses: ruby/setup-ruby@v1 with: @@ -60,7 +60,7 @@ jobs: - name: Run tests run: bundle exec rails test:all - name: Report completion to Coveralls - uses: coverallsapp/github-action@v2.2.1 + uses: coverallsapp/github-action@v2.2.2 with: github-token: ${{ secrets.github_token }} flag-name: ubuntu-${{ matrix.ubuntu }}-ruby-${{ matrix.ruby }} @@ -72,7 +72,7 @@ jobs: runs-on: ubuntu-latest steps: - name: Report completion to Coveralls - uses: coverallsapp/github-action@v2.2.1 + uses: coverallsapp/github-action@v2.2.2 with: github-token: ${{ secrets.github_token }} parallel-finished: true diff --git a/.rubocop.yml b/.rubocop.yml index dc2a33a35..f8060f948 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -17,6 +17,11 @@ AllCops: Rails: Enabled: true +# Config can be removed after https://github.com/rubocop/rubocop-factory_bot/issues/53 +FactoryBot/AssociationStyle: + Include: + - 'test/factories/**/*' + Layout/ExtraSpacing: AllowForAlignment: true diff --git a/Gemfile.lock b/Gemfile.lock index e58f26e1a..13c1a5927 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -79,14 +79,14 @@ GEM annotate (3.2.0) activerecord (>= 3.2, < 8.0) rake (>= 10.4, < 14.0) - argon2 (2.2.0) + argon2 (2.3.0) ffi (~> 1.15) ffi-compiler (~> 1.0) ast (2.4.2) autoprefixer-rails (10.4.13.0) execjs (~> 2) aws-eventstream (1.2.0) - aws-partitions (1.813.0) + aws-partitions (1.816.0) aws-sdk-core (3.181.0) aws-eventstream (~> 1, >= 1.0.2) aws-partitions (~> 1, >= 1.651.0) @@ -228,8 +228,8 @@ GEM fspath (3.1.2) gd2-ffij (0.4.0) ffi (>= 1.0.0) - globalid (1.1.0) - activesupport (>= 5.0) + globalid (1.2.0) + activesupport (>= 6.1) hashdiff (1.0.1) hashie (5.0.0) highline (2.1.0) @@ -368,7 +368,7 @@ GEM parser (3.2.2.3) ast (~> 2.4.1) racc - pg (1.5.3) + pg (1.5.4) popper_js (2.11.8) progress (3.6.0) public_suffix (5.0.3) @@ -433,7 +433,7 @@ GEM rack (>= 1.4) rexml (3.2.6) rinku (2.0.6) - rotp (6.2.2) + rotp (6.3.0) rouge (4.1.3) rubocop (1.56.2) base64 (~> 0.1.1) @@ -453,7 +453,7 @@ GEM rubocop (~> 1.41) rubocop-factory_bot (2.23.1) rubocop (~> 1.33) - rubocop-minitest (0.31.0) + rubocop-minitest (0.31.1) rubocop (>= 1.39, < 2.0) rubocop-performance (1.19.0) rubocop (>= 1.7.0, < 2.0) @@ -482,7 +482,7 @@ GEM sprockets-rails tilt secure_headers (6.5.0) - selenium-webdriver (4.11.0) + selenium-webdriver (4.12.0) rexml (~> 3.2, >= 3.2.5) rubyzip (>= 1.2.2, < 3.0) websocket (~> 1.0) @@ -523,7 +523,7 @@ GEM i18n vendorer (0.2.0) version_gem (1.1.3) - webmock (3.19.0) + webmock (3.19.1) addressable (>= 2.8.0) crack (>= 0.3.2) hashdiff (>= 0.4.0, < 2.0.0) diff --git a/app/assets/javascripts/leaflet.layers.js b/app/assets/javascripts/leaflet.layers.js index 020876c47..27311f7c1 100644 --- a/app/assets/javascripts/leaflet.layers.js +++ b/app/assets/javascripts/leaflet.layers.js @@ -8,11 +8,12 @@ L.OSM.layers = function (options) { .attr("class", "section base-layers") .appendTo($ui); - var baseLayers = $("