From: Tom Hughes <tom@compton.nu>
Date: Wed, 30 Mar 2022 21:26:39 +0000 (+0100)
Subject: Uniqify counts for containing ways and relations on browse pages
X-Git-Tag: live~1244
X-Git-Url: https://git.openstreetmap.org/rails.git/commitdiff_plain/f2656f925e5f47ef6ce58dc014556b34f2d83f6a

Uniqify counts for containing ways and relations on browse pages

Fixes #3519
---

diff --git a/app/views/browse/_node.html.erb b/app/views/browse/_node.html.erb
index 77d3a5c16..152223ae7 100644
--- a/app/views/browse/_node.html.erb
+++ b/app/views/browse/_node.html.erb
@@ -14,7 +14,7 @@
       <h4><%= t "browse.part_of" %></h4>
       <% unless node.ways.empty? %>
         <details <%= "open" if node.ways.count < 10 %>>
-          <summary><%= t "browse.part_of_ways", :count => node.ways.count %></summary>
+          <summary><%= t "browse.part_of_ways", :count => node.ways.uniq.count %></summary>
           <ul class="list-unstyled">
             <% node.ways.uniq.each do |way| %>
               <li><%= link_to printable_name(way), { :action => "way", :id => way.id.to_s }, { :class => link_class("way", way), :title => link_title(way) } %></li>
@@ -24,7 +24,7 @@
       <% end %>
       <% unless node.containing_relation_members.empty? %>
         <details <%= "open" if node.containing_relation_members.count < 10 %>>
-          <summary><%= t "browse.part_of_relations", :count => node.containing_relation_members.count %></summary>
+          <summary><%= t "browse.part_of_relations", :count => node.containing_relation_members.uniq.count %></summary>
           <ul class="list-unstyled">
             <%= render :partial => "containing_relation", :collection => node.containing_relation_members.uniq %>
           </ul>
diff --git a/app/views/browse/_relation.html.erb b/app/views/browse/_relation.html.erb
index cf9c62b13..8db40c8c7 100644
--- a/app/views/browse/_relation.html.erb
+++ b/app/views/browse/_relation.html.erb
@@ -13,7 +13,7 @@
     <% unless relation.containing_relation_members.empty? %>
       <h4><%= t "browse.part_of" %></h4>
       <details <%= "open" if relation.containing_relation_members.count < 10 %>>
-        <summary><%= t "browse.part_of_relations", :count => relation.containing_relation_members.count %></summary>
+        <summary><%= t "browse.part_of_relations", :count => relation.containing_relation_members.uniq.count %></summary>
         <ul class="list-unstyled">
           <%= render :partial => "containing_relation", :collection => relation.containing_relation_members.uniq %>
         </ul>
diff --git a/app/views/browse/_way.html.erb b/app/views/browse/_way.html.erb
index d99919e64..4fdcd035e 100644
--- a/app/views/browse/_way.html.erb
+++ b/app/views/browse/_way.html.erb
@@ -13,7 +13,7 @@
     <% unless way.containing_relation_members.empty? %>
       <h4><%= t "browse.part_of" %></h4>
       <details <%= "open" if way.containing_relation_members.count < 10 %>>
-        <summary><%= t "browse.part_of_relations", :count => way.containing_relation_members.count %></summary>
+        <summary><%= t "browse.part_of_relations", :count => way.containing_relation_members.uniq.count %></summary>
         <ul class="list-unstyled">
           <%= render :partial => "containing_relation", :collection => way.containing_relation_members.uniq %>
         </ul>