From: Andy Allan <git@gravitystorm.co.uk>
Date: Wed, 14 Mar 2018 09:35:58 +0000 (+0800)
Subject: Refactor set_default_assigned_role to be more easily read.
X-Git-Tag: live~2943^2~18
X-Git-Url: https://git.openstreetmap.org/rails.git/commitdiff_plain/facce9d0bb04ebdaa185c65eb8772aa7ff4db01f

Refactor set_default_assigned_role to be more easily read.
---

diff --git a/app/models/issue.rb b/app/models/issue.rb
index 00ee934f7..c02254a1b 100644
--- a/app/models/issue.rb
+++ b/app/models/issue.rb
@@ -95,7 +95,11 @@ class Issue < ActiveRecord::Base
   end
 
   def set_default_assigned_role
-    role = %w[Note].include?(reportable.class.name) ? "moderator" : "administrator"
-    self.assigned_role = role if assigned_role.blank?
+    if assigned_role.blank?
+      self.assigned_role = case reportable
+                           when Note then "moderator"
+                           else "administrator"
+                           end
+    end
   end
 end