From: Tom Hughes <tom@compton.nu>
Date: Wed, 17 Aug 2016 09:02:50 +0000 (+0100)
Subject: Make banner cookies expire after one year
X-Git-Tag: live~3819
X-Git-Url: https://git.openstreetmap.org/rails.git/commitdiff_plain/fb9afd32db582cda6cebfbb84c93c0aa2b4bbb03

Make banner cookies expire after one year

This avoids having lots of cookies stick around forever and
we shouldn't ever have a banner up for that long.
---

diff --git a/app/assets/javascripts/index.js b/app/assets/javascripts/index.js
index 9ebee2dd2..782b9363c 100644
--- a/app/assets/javascripts/index.js
+++ b/app/assets/javascripts/index.js
@@ -174,12 +174,15 @@ $(document).ready(function () {
     $.cookie('_osm_welcome', 'hide', { expires: expiry });
   });
 
+  var bannerExpiry = new Date();
+  expiry.setYear(expiry.getFullYear() + 1);
+
   $('#banner .close-wrap').on('click', function(e) {
     var cookieId = e.target.id;
     $('#banner').hide();
     e.preventDefault();
     if (cookieId) {
-      $.cookie(cookieId, 'hide', { expires: expiry });
+      $.cookie(cookieId, 'hide', { expires: bannerExpiry });
     }
   });