From: Tom Hughes <tom@compton.nu>
Date: Sat, 4 Oct 2008 23:20:58 +0000 (+0000)
Subject: Fix test for errors from geocoder.ca to work properly. Closes #1213.
X-Git-Tag: live~7696
X-Git-Url: https://git.openstreetmap.org/rails.git/commitdiff_plain/fe37259e012cdeef1e22e1dfb887be108193a086?ds=sidebyside

Fix test for errors from geocoder.ca to work properly. Closes #1213.
---

diff --git a/app/controllers/geocoder_controller.rb b/app/controllers/geocoder_controller.rb
index 79da2f6e9..531cce422 100644
--- a/app/controllers/geocoder_controller.rb
+++ b/app/controllers/geocoder_controller.rb
@@ -102,7 +102,7 @@ private
     response = fetch_xml("http://geocoder.ca/?geoit=XML&postal=#{escape_query(query)}")
 
     # parse the response
-    unless response.get_elements("geodata/error")
+    if response.get_elements("geodata/error").empty?
       results.push({:lat => response.get_text("geodata/latt").to_s,
                     :lon => response.get_text("geodata/longt").to_s,
                     :zoom => POSTCODE_ZOOM,