From 02f31aa81ca28357d3bc4653f29e3044a204ccc2 Mon Sep 17 00:00:00 2001
From: Tom Hughes <tom@compton.nu>
Date: Thu, 1 Oct 2026 08:03:30 +0100
Subject: [PATCH] Avoid persisting test records unecessarily

---
 test/models/old_node_tag_test.rb     | 10 +++++-----
 test/models/old_relation_tag_test.rb | 10 +++++-----
 test/models/old_way_tag_test.rb      | 10 +++++-----
 3 files changed, 15 insertions(+), 15 deletions(-)

diff --git a/test/models/old_node_tag_test.rb b/test/models/old_node_tag_test.rb
index c1bc8bdd0..cc7f62a18 100644
--- a/test/models/old_node_tag_test.rb
+++ b/test/models/old_node_tag_test.rb
@@ -4,7 +4,7 @@ require "test_helper"
 
 class OldNodeTagTest < ActiveSupport::TestCase
   def test_length_key_valid
-    tag = create(:old_node_tag)
+    tag = build(:old_node_tag)
     [0, 255].each do |i|
       tag.k = "k" * i
       assert_predicate tag, :valid?
@@ -12,7 +12,7 @@ class OldNodeTagTest < ActiveSupport::TestCase
   end
 
   def test_length_value_valid
-    tag = create(:old_node_tag)
+    tag = build(:old_node_tag)
     [0, 255].each do |i|
       tag.v = "v" * i
       assert_predicate tag, :valid?
@@ -20,21 +20,21 @@ class OldNodeTagTest < ActiveSupport::TestCase
   end
 
   def test_length_key_invalid
-    tag = create(:old_node_tag)
+    tag = build(:old_node_tag)
     tag.k = "k" * 256
     assert_not_predicate tag, :valid?
     assert_predicate tag.errors[:k], :any?
   end
 
   def test_length_value_invalid
-    tag = create(:old_node_tag)
+    tag = build(:old_node_tag)
     tag.v = "v" * 256
     assert_not_predicate tag, :valid?, "Value should be too long"
     assert_predicate tag.errors[:v], :any?
   end
 
   def test_orphaned_tag_invalid
-    tag = create(:old_node_tag)
+    tag = build(:old_node_tag)
     tag.old_node = nil
     assert_not_predicate tag, :valid?, "Orphaned tag should be invalid"
     assert_predicate tag.errors[:old_node], :any?
diff --git a/test/models/old_relation_tag_test.rb b/test/models/old_relation_tag_test.rb
index 32790dbc6..3736ff50d 100644
--- a/test/models/old_relation_tag_test.rb
+++ b/test/models/old_relation_tag_test.rb
@@ -4,7 +4,7 @@ require "test_helper"
 
 class OldRelationTagTest < ActiveSupport::TestCase
   def test_length_key_valid
-    tag = create(:old_relation_tag)
+    tag = build(:old_relation_tag)
     [0, 255].each do |i|
       tag.k = "k" * i
       assert_predicate tag, :valid?
@@ -12,7 +12,7 @@ class OldRelationTagTest < ActiveSupport::TestCase
   end
 
   def test_length_value_valid
-    tag = create(:old_relation_tag)
+    tag = build(:old_relation_tag)
     [0, 255].each do |i|
       tag.v = "v" * i
       assert_predicate tag, :valid?
@@ -20,21 +20,21 @@ class OldRelationTagTest < ActiveSupport::TestCase
   end
 
   def test_length_key_invalid
-    tag = create(:old_relation_tag)
+    tag = build(:old_relation_tag)
     tag.k = "k" * 256
     assert_not_predicate tag, :valid?, "Key should be too long"
     assert_predicate tag.errors[:k], :any?
   end
 
   def test_length_value_invalid
-    tag = create(:old_relation_tag)
+    tag = build(:old_relation_tag)
     tag.v = "v" * 256
     assert_not_predicate tag, :valid?, "Value should be too long"
     assert_predicate tag.errors[:v], :any?
   end
 
   def test_orphaned_tag_invalid
-    tag = create(:old_relation_tag)
+    tag = build(:old_relation_tag)
     tag.old_relation = nil
     assert_not_predicate tag, :valid?, "Orphaned tag should be invalid"
     assert_predicate tag.errors[:old_relation], :any?
diff --git a/test/models/old_way_tag_test.rb b/test/models/old_way_tag_test.rb
index 4873dc9e6..9a8f3312a 100644
--- a/test/models/old_way_tag_test.rb
+++ b/test/models/old_way_tag_test.rb
@@ -4,7 +4,7 @@ require "test_helper"
 
 class OldWayTagTest < ActiveSupport::TestCase
   def test_length_key_valid
-    tag = create(:old_way_tag)
+    tag = build(:old_way_tag)
     [0, 255].each do |i|
       tag.k = "k" * i
       assert_predicate tag, :valid?
@@ -12,7 +12,7 @@ class OldWayTagTest < ActiveSupport::TestCase
   end
 
   def test_length_value_valid
-    tag = create(:old_way_tag)
+    tag = build(:old_way_tag)
     [0, 255].each do |i|
       tag.v = "v" * i
       assert_predicate tag, :valid?
@@ -20,21 +20,21 @@ class OldWayTagTest < ActiveSupport::TestCase
   end
 
   def test_length_key_invalid
-    tag = create(:old_way_tag)
+    tag = build(:old_way_tag)
     tag.k = "k" * 256
     assert_not_predicate tag, :valid?, "Key should be too long"
     assert_predicate tag.errors[:k], :any?
   end
 
   def test_length_value_invalid
-    tag = create(:old_way_tag)
+    tag = build(:old_way_tag)
     tag.v = "v" * 256
     assert_not_predicate tag, :valid?, "Value should be too long"
     assert_predicate tag.errors[:v], :any?
   end
 
   def test_orphaned_tag_invalid
-    tag = create(:old_way_tag)
+    tag = build(:old_way_tag)
     tag.old_way = nil
     assert_not_predicate tag, :valid?, "Orphaned tag should be invalid"
     assert_predicate tag.errors[:old_way], :any?
-- 
2.47.3