From 056848550d00b4cb49d7b8cda0418c570bdf51bd Mon Sep 17 00:00:00 2001
From: Pablo Brasero <pablo@pablobm.com>
Date: Wed, 11 Mar 2026 14:27:01 +0000
Subject: [PATCH] Simpler way to use URL helpers in mailer tests

---
 test/mailers/user_mailer_test.rb | 38 ++++++++++++++++++++++++++------
 1 file changed, 31 insertions(+), 7 deletions(-)

diff --git a/test/mailers/user_mailer_test.rb b/test/mailers/user_mailer_test.rb
index 3553a0f93..5d16df0f0 100644
--- a/test/mailers/user_mailer_test.rb
+++ b/test/mailers/user_mailer_test.rb
@@ -24,7 +24,7 @@ class UserMailerTest < ActionMailer::TestCase
   def test_gpx_success_all_traces_link
     trace = create(:trace)
     email = UserMailer.gpx_success(trace, 100)
-    url = Rails.application.routes.url_helpers.url_for(:controller => "traces", :action => "mine", :host => Settings.server_url, :protocol => Settings.server_protocol)
+    url = url_helpers.url_for(:controller => "traces", :action => "mine")
 
     assert_select Rails::Dom::Testing.html_document_fragment.parse(email.html_part.body),
                   "a[href='#{url}']"
@@ -34,7 +34,7 @@ class UserMailerTest < ActionMailer::TestCase
   def test_gpx_success_trace_link
     trace = create(:trace)
     email = UserMailer.gpx_success(trace, 100)
-    url = Rails.application.routes.url_helpers.show_trace_url(trace.user, trace, :host => Settings.server_url, :protocol => Settings.server_protocol)
+    url = url_helpers.show_trace_url(trace.user, trace)
 
     assert_select Rails::Dom::Testing.html_document_fragment.parse(email.html_part.body),
                   "a[href='#{url}']", :text => trace.name
@@ -44,7 +44,7 @@ class UserMailerTest < ActionMailer::TestCase
   def test_gpx_failure_no_trace_link
     trace = create(:trace)
     email = UserMailer.gpx_failure(trace, "some error")
-    url = Rails.application.routes.url_helpers.show_trace_url(trace.user, trace, :host => Settings.server_url, :protocol => Settings.server_protocol)
+    url = url_helpers.show_trace_url(trace.user, trace)
 
     assert_select Rails::Dom::Testing.html_document_fragment.parse(email.html_part.body),
                   "a[href='#{url}']", :count => 0
@@ -69,8 +69,8 @@ class UserMailerTest < ActionMailer::TestCase
     email = UserMailer.diary_comment_notification(diary_comment, other_user)
     body = Rails::Dom::Testing.html_document_fragment.parse(email.html_part.body)
 
-    url = Rails.application.routes.url_helpers.diary_entry_url(user, diary_entry, :host => Settings.server_url, :protocol => Settings.server_protocol)
-    unsubscribe_url = Rails.application.routes.url_helpers.diary_entry_unsubscribe_url(user, diary_entry, :host => Settings.server_url, :protocol => Settings.server_protocol)
+    url = url_helpers.diary_entry_url(user, diary_entry)
+    unsubscribe_url = url_helpers.diary_entry_unsubscribe_url(user, diary_entry)
     assert_select body, "a[href^='#{url}']"
     assert_select body, "a[href='#{unsubscribe_url}']", :count => 1
   end
@@ -84,9 +84,33 @@ class UserMailerTest < ActionMailer::TestCase
     email = UserMailer.changeset_comment_notification(changeset_comment, other_user)
     body = Rails::Dom::Testing.html_document_fragment.parse(email.html_part.body)
 
-    url = Rails.application.routes.url_helpers.changeset_url(changeset, :host => Settings.server_url, :protocol => Settings.server_protocol)
-    unsubscribe_url = Rails.application.routes.url_helpers.changeset_subscription_url(changeset, :host => Settings.server_url, :protocol => Settings.server_protocol)
+    url = url_helpers.changeset_url(changeset)
+    unsubscribe_url = url_helpers.changeset_subscription_url(changeset)
     assert_select body, "a[href^='#{url}']"
     assert_select body, "a[href='#{unsubscribe_url}']", :count => 1
   end
+
+  private
+
+  def url_helpers
+    UrlHelpers.new
+  end
+
+  class UrlHelpers
+    def method_missing(method, *args)
+      opts = args.extract_options!
+      opts.reverse_merge!(:host => Settings.server_url, :protocol => Settings.server_protocol)
+      url_helpers.send(method, *args, opts)
+    end
+
+    def respond_to_missing?(method, include_all)
+      url_helpers.respond_to?(method, include_all)
+    end
+
+    private
+
+    def url_helpers
+      Rails.application.routes.url_helpers
+    end
+  end
 end
-- 
2.47.3