From 1455a7d8eb1c2e0448ff3b09e3f51559fcff4ddf Mon Sep 17 00:00:00 2001
From: Anton Khorev <tony29@yandex.ru>
Date: Thu, 19 Jun 2025 03:09:04 +0300
Subject: [PATCH] Update element versions list using Turbo streams

---
 app/controllers/old_nodes_controller.rb       |  5 ++
 app/views/old_elements/index.html.erb         | 18 +++++--
 app/views/old_elements/index.turbo_stream.erb | 33 ++++++++++++
 test/system/element_history_test.rb           | 53 +++++++++++++++++++
 4 files changed, 104 insertions(+), 5 deletions(-)
 create mode 100644 app/views/old_elements/index.turbo_stream.erb
 create mode 100644 test/system/element_history_test.rb

diff --git a/app/controllers/old_nodes_controller.rb b/app/controllers/old_nodes_controller.rb
index 7901e5abf..02a4ad9e1 100644
--- a/app/controllers/old_nodes_controller.rb
+++ b/app/controllers/old_nodes_controller.rb
@@ -7,6 +7,11 @@ class OldNodesController < OldElementsController
       :cursor_column => :version,
       :includes => [:old_tags, { :changeset => [:changeset_tags, :user] }]
     )
+
+    respond_to do |format|
+      format.turbo_stream
+      format.html
+    end
   rescue ActiveRecord::RecordNotFound
     render "browse/not_found", :status => :not_found
   end
diff --git a/app/views/old_elements/index.html.erb b/app/views/old_elements/index.html.erb
index 3e0f41175..a3db93746 100644
--- a/app/views/old_elements/index.html.erb
+++ b/app/views/old_elements/index.html.erb
@@ -3,19 +3,27 @@
 <%= render "sidebar_header", :title => t(".#{@type}.title_html", :name => printable_element_name(@feature)) %>
 
 <% if @newer_features_version %>
-  <ul class="pagination justify-content-center">
+  <ul id="newer_element_versions_navigation" class="pagination justify-content-center">
     <li class="page-item">
-      <%= link_to t(".newer_versions"), params.permit(:show_redactions).merge(:after => @newer_features_version), :class => "page-link" %>
+      <%= link_to t(".newer_versions"),
+                  params.permit(:show_redactions).merge(:after => @newer_features_version),
+                  :class => "page-link",
+                  :data => { :turbo => true, :turbo_stream => true } %>
     </li>
   </ul>
 <% end %>
 
-<%= render :partial => "browse/#{@type}", :collection => @old_features %>
+<div id="element_versions_list">
+  <%= render :partial => "browse/#{@type}", :collection => @old_features %>
+</div>
 
 <% if @older_features_version %>
-  <ul class="pagination justify-content-center">
+  <ul id="older_element_versions_navigation" class="pagination justify-content-center">
     <li class="page-item">
-      <%= link_to t(".older_versions"), params.permit(:show_redactions).merge(:before => @older_features_version), :class => "page-link" %>
+      <%= link_to t(".older_versions"),
+                  params.permit(:show_redactions).merge(:before => @older_features_version),
+                  :class => "page-link",
+                  :data => { :turbo => true, :turbo_stream => true } %>
     </li>
   </ul>
 <% end %>
diff --git a/app/views/old_elements/index.turbo_stream.erb b/app/views/old_elements/index.turbo_stream.erb
new file mode 100644
index 000000000..93a600a67
--- /dev/null
+++ b/app/views/old_elements/index.turbo_stream.erb
@@ -0,0 +1,33 @@
+<% if params[:after] %>
+  <% if @newer_features_version %>
+    <%= turbo_stream.update "newer_element_versions_navigation" do %>
+      <li class="page-item">
+        <%= link_to t(".newer_versions"),
+                    params.permit(:show_redactions).merge(:after => @newer_features_version),
+                    :class => "page-link",
+                    :data => { :turbo => true, :turbo_stream => true } %>
+      </li>
+    <% end %>
+  <% else %>
+    <%= turbo_stream.remove "newer_element_versions_navigation" %>
+  <% end %>
+  <%= turbo_stream.prepend "element_versions_list" do %>
+    <%= render :partial => "browse/#{@type}", :formats => [:html], :collection => @old_features %>
+  <% end %>
+<% elsif params[:before] %>
+  <%= turbo_stream.append "element_versions_list" do %>
+    <%= render :partial => "browse/#{@type}", :formats => [:html], :collection => @old_features %>
+  <% end %>
+  <% if @older_features_version %>
+    <%= turbo_stream.update "older_element_versions_navigation" do %>
+      <li class="page-item">
+        <%= link_to t(".older_versions"),
+                    params.permit(:show_redactions).merge(:before => @older_features_version),
+                    :class => "page-link",
+                    :data => { :turbo => true, :turbo_stream => true } %>
+      </li>
+    <% end %>
+  <% else %>
+    <%= turbo_stream.remove "older_element_versions_navigation" %>
+  <% end %>
+<% end %>
diff --git a/test/system/element_history_test.rb b/test/system/element_history_test.rb
new file mode 100644
index 000000000..11b5397c0
--- /dev/null
+++ b/test/system/element_history_test.rb
@@ -0,0 +1,53 @@
+require "application_system_test_case"
+
+class ElementHistoryTest < ApplicationSystemTestCase
+  test "can view node history" do
+    node = create(:node, :with_history, :version => 41)
+
+    visit node_path(node)
+
+    check_element_history(->(v) { old_node_path(node, v) })
+  end
+
+  test "can view way history" do
+    way = create(:way, :with_history, :version => 41)
+
+    visit way_path(way)
+
+    check_element_history(->(v) { old_way_path(way, v) })
+  end
+
+  test "can view relation history" do
+    relation = create(:relation, :with_history, :version => 41)
+
+    visit relation_path(relation)
+
+    check_element_history(->(v) { old_relation_path(relation, v) })
+  end
+
+  private
+
+  def check_element_history(get_path)
+    within_sidebar do
+      click_on "View History"
+
+      41.downto(22) do |v|
+        assert_link v.to_s, :href => get_path.call(v)
+      end
+
+      click_on "Older Versions"
+
+      41.downto(2) do |v|
+        assert_link v.to_s, :href => get_path.call(v)
+      end
+
+      click_on "Older Versions"
+
+      41.downto(1) do |v|
+        assert_link v.to_s, :href => get_path.call(v)
+      end
+
+      assert_no_link "Older Versions"
+    end
+  end
+end
-- 
2.39.5