From 162f04d789a0f9efcbabc37eed571e5a591e67bf Mon Sep 17 00:00:00 2001
From: Andy Allan <git@gravitystorm.co.uk>
Date: Wed, 26 Oct 2016 09:15:56 +0100
Subject: [PATCH] Convert ACL fixture to a factory, and add some tests

The fixture was unused, so I took the opportunity to put in a couple
of basic model tests.
---
 app/models/acl.rb       |  2 ++
 test/factories/acls.rb  |  5 +++++
 test/fixtures/acls.yml  | 13 -------------
 test/models/acl_test.rb | 20 +++++++++++++++++---
 4 files changed, 24 insertions(+), 16 deletions(-)
 create mode 100644 test/factories/acls.rb
 delete mode 100644 test/fixtures/acls.yml

diff --git a/app/models/acl.rb b/app/models/acl.rb
index 8bb4ae4b9..529ccbe3b 100644
--- a/app/models/acl.rb
+++ b/app/models/acl.rb
@@ -1,4 +1,6 @@
 class Acl < ActiveRecord::Base
+  validates :k, :presence => true
+
   def self.match(address, domain = nil)
     if domain
       Acl.where("address >>= ? OR domain = ?", address, domain)
diff --git a/test/factories/acls.rb b/test/factories/acls.rb
new file mode 100644
index 000000000..3f91df3ab
--- /dev/null
+++ b/test/factories/acls.rb
@@ -0,0 +1,5 @@
+FactoryGirl.define do
+  factory :acl do
+    sequence(:k) { |n| "Key #{n}" }
+  end
+end
diff --git a/test/fixtures/acls.yml b/test/fixtures/acls.yml
deleted file mode 100644
index 399e08808..000000000
--- a/test/fixtures/acls.yml
+++ /dev/null
@@ -1,13 +0,0 @@
-# Read about fixtures at http://ar.rubyonrails.org/classes/Fixtures.html
-
-one:
-  address: 1
-  netmask: 1
-  k: MyText
-  v: MyText
-
-two:
-  address: 1
-  netmask: 1
-  k: MyText
-  v: MyText
diff --git a/test/models/acl_test.rb b/test/models/acl_test.rb
index 4022b8adb..189f92677 100644
--- a/test/models/acl_test.rb
+++ b/test/models/acl_test.rb
@@ -1,8 +1,22 @@
 require "test_helper"
 
 class AclTest < ActiveSupport::TestCase
-  # Replace this with your real tests.
-  def test_truth
-    assert true
+  def test_k_required
+    acl = create(:acl)
+    assert acl.valid?
+    acl.k = nil
+    assert !acl.valid?
+  end
+
+  def test_no_account_creation_by_subnet
+    assert !Acl.no_account_creation("192.168.1.1")
+    create(:acl, :address => "192.168.0.0/16", :k => "no_account_creation")
+    assert Acl.no_account_creation("192.168.1.1")
+  end
+
+  def test_no_account_creation_by_domain
+    assert !Acl.no_account_creation("192.168.1.1", "example.com")
+    create(:acl, :domain => "example.com", :k => "no_account_creation")
+    assert Acl.no_account_creation("192.168.1.1", "example.com")
   end
 end
-- 
2.43.2