From 17e07539629ee8a1fdb5bebbb4c287720905066e Mon Sep 17 00:00:00 2001
From: Tom Hughes <tom@compton.nu>
Date: Thu, 15 Oct 2009 09:27:21 +0000
Subject: [PATCH] Use bounding box information to zoom to search results when
 possible.

---
 app/controllers/geocoder_controller.rb |  7 +++++--
 app/helpers/geocoder_helper.rb         |  8 +++++++-
 app/views/site/index.html.erb          | 10 ++++++++--
 3 files changed, 20 insertions(+), 5 deletions(-)

diff --git a/app/controllers/geocoder_controller.rb b/app/controllers/geocoder_controller.rb
index 66c2ae417..9f90980bf 100644
--- a/app/controllers/geocoder_controller.rb
+++ b/app/controllers/geocoder_controller.rb
@@ -223,7 +223,7 @@ class GeocoderController < ApplicationController
     @results = Array.new
 
     # ask OSM namefinder
-    response = fetch_xml("http://katie.openstreetmap.org/~twain/?format=xml&q=#{escape_query(query)}")
+    response = fetch_xml("http://katie.openstreetmap.org/~twain/?format=xml&polygon=true&q=#{escape_query(query)}")
 
     # parse the response
     response.elements.each("searchresults/place") do |place|
@@ -233,6 +233,7 @@ class GeocoderController < ApplicationController
       klass = place.attributes["class"].to_s
       type = place.attributes["type"].to_s
       name = place.attributes["display_name"].to_s
+      min_lat,max_lat,min_lon,max_lon = place.attributes["boundingbox"].to_s.split(",")
 
       if klass == "highway"
         prefix = t 'geocoder.search_osm_twain.prefix_highway', :type => type.capitalize
@@ -241,6 +242,8 @@ class GeocoderController < ApplicationController
       end
 
       @results.push({:lat => lat, :lon => lon, :zoom => zoom,
+                     :min_lat => min_lat, :max_lat => max_lat,
+                     :min_lon => min_lon, :max_lon => max_lon,
                      :prefix => prefix, :name => name})
     end
 
@@ -277,7 +280,7 @@ class GeocoderController < ApplicationController
     @error = "Error contacting ws.geonames.org: #{ex.to_s}"
     render :action => "error"
   end
-  
+
   def description
     @sources = Array.new
 
diff --git a/app/helpers/geocoder_helper.rb b/app/helpers/geocoder_helper.rb
index e7d0ddf6c..254412b51 100644
--- a/app/helpers/geocoder_helper.rb
+++ b/app/helpers/geocoder_helper.rb
@@ -6,7 +6,13 @@ module GeocoderHelper
     html = ""
     html << result[:prefix] if result[:prefix]
     html << " " if result[:prefix] and result[:name]
-    html << link_to_function(result[:name],"setPosition(#{result[:lat]}, #{result[:lon]}, #{result[:zoom]})", html_options)  if result[:name]
+
+    if result[:min_lon] and result[:min_lat] and result[:max_lon] and result[:max_lat]
+      html << link_to_function(result[:name],"setPosition(#{result[:lat]}, #{result[:lon]}, #{result[:zoom]}, #{result[:min_lon]}, #{result[:min_lat]}, #{result[:max_lon]}, #{result[:max_lat]})", html_options)  if result[:name]
+    else
+      html << link_to_function(result[:name],"setPosition(#{result[:lat]}, #{result[:lon]}, #{result[:zoom]})", html_options)  if result[:name]
+    end
+
     html << result[:suffix] if result[:suffix]
     return html
   end
diff --git a/app/views/site/index.html.erb b/app/views/site/index.html.erb
index 40a7a3fbc..12cc1d275 100644
--- a/app/views/site/index.html.erb
+++ b/app/views/site/index.html.erb
@@ -191,10 +191,16 @@ end
     return getMapCenter();
   }
 
-  function setPosition(lat, lon, zoom) {
+  function setPosition(lat, lon, zoom, min_lon, min_lat, max_lon, max_lat) {
     var centre = new OpenLayers.LonLat(lon, lat);
 
-    setMapCenter(centre, zoom);
+    if (min_lon && min_lat && max_lon && max_lat) {
+      var bbox = new OpenLayers.Bounds(min_lon, min_lat, max_lon, max_lat);
+
+      setMapExtent(bbox);
+    } else {
+      setMapCenter(centre, zoom);
+    }
 
     if (marker)
       removeMarkerFromMap(marker);
-- 
2.43.2