From 1813c04e6627365e22b2536d99a535a08dff986e Mon Sep 17 00:00:00 2001 From: Anton Khorev Date: Mon, 19 May 2025 17:17:43 +0300 Subject: [PATCH] Use spans instead of divs in all heatmap cells Previously nonempty cells were divs wrapped by links. --- app/assets/javascripts/heatmap.js | 2 +- app/assets/stylesheets/common.scss | 4 ++-- app/views/users/_heatmap.html.erb | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/app/assets/javascripts/heatmap.js b/app/assets/javascripts/heatmap.js index 683b46222..15809cc0b 100644 --- a/app/assets/javascripts/heatmap.js +++ b/app/assets/javascripts/heatmap.js @@ -48,7 +48,7 @@ $(function () { customClass: "wide", delay: { show: 0, hide: 0 } }) - .find("div") + .find("span") .css("opacity", Math.sqrt(count / maxPerDay)); } heatmap.find(`[data-month="${previousMonth}"] ~ [data-month]`).remove(); diff --git a/app/assets/stylesheets/common.scss b/app/assets/stylesheets/common.scss index 9501c19a2..6043a67bf 100644 --- a/app/assets/stylesheets/common.scss +++ b/app/assets/stylesheets/common.scss @@ -970,7 +970,7 @@ img.trace_image { font-size: x-small; gap: 0.3em; - [data-date], [data-date] div { + [data-date], [data-date] span { display: block; aspect-ratio: 1; border-radius: 25%; @@ -978,7 +978,7 @@ img.trace_image { [data-date] { @extend .bg-body-secondary, .bg-opacity-75; - div { + span { background-color: $green; } &:hover { diff --git a/app/views/users/_heatmap.html.erb b/app/views/users/_heatmap.html.erb index 73cd2c94a..76d4d527c 100644 --- a/app/views/users/_heatmap.html.erb +++ b/app/views/users/_heatmap.html.erb @@ -15,7 +15,7 @@ <% if day[:total_changes] == 0 %> <% else %> -
+ <% end %> <% end %> -- 2.39.5