From 22fefc3df0c9302c2756f2cbbb2cdd011174a3a5 Mon Sep 17 00:00:00 2001
From: Tom Hughes <tom@compton.nu>
Date: Tue, 19 Feb 2019 10:06:58 +0000
Subject: [PATCH] Set language and text direction properly on the copyright
 page

Also add style overrides for explicit LTR and RTL text that work
independently of the main page styling.

Fixes #2148
---
 app/assets/stylesheets/common.scss |   4 +
 app/views/site/copyright.html.erb  | 120 +++++++++++++++--------------
 2 files changed, 68 insertions(+), 56 deletions(-)

diff --git a/app/assets/stylesheets/common.scss b/app/assets/stylesheets/common.scss
index d725cc287..8cdd57a4e 100644
--- a/app/assets/stylesheets/common.scss
+++ b/app/assets/stylesheets/common.scss
@@ -150,6 +150,10 @@ small, aside {
 
 .piwik { border: 0; }
 
+[dir=rtl] { /* no-r2 */ text-align: right; }
+
+[dir=ltr] { /* no-r2 */ text-align: left; }
+
 /* Rules for icons */
 
 .icon {
diff --git a/app/views/site/copyright.html.erb b/app/views/site/copyright.html.erb
index 25504948f..ce766fe34 100644
--- a/app/views/site/copyright.html.erb
+++ b/app/views/site/copyright.html.erb
@@ -3,75 +3,83 @@
   <!-- Maybe ease foreigners back to their native page -->
 
     <% if t('.legal_babble', :locale => I18n.locale) != t('.legal_babble', :locale => :en) %>
-      <h1><%= t '.native.title' %></h1>
-      <p>
-        <%= raw t '.native.text',
-                    :native_link => link_to(t('.native.native_link'),
-                                                :controller => 'site',
-                                                :action => 'copyright',
-                                                :copyright_locale => nil),
-                    :mapping_link => link_to(t('.native.mapping_link'),
-                                                :controller => 'site',
-                                                :action => 'index') %>
-      </p>
+      <%= tag.h1 :lang => @locale, :dir => t("html.dir", :locale => @locale) do %>
+        <h1><%= t '.native.title' %></h1>
+        <p>
+          <%= raw t '.native.text',
+                      :native_link => link_to(t('.native.native_link'),
+                                                  :controller => 'site',
+                                                  :action => 'copyright',
+                                                  :copyright_locale => nil),
+                      :mapping_link => link_to(t('.native.mapping_link'),
+                                                  :controller => 'site',
+                                                  :action => 'index') %>
+        </p>
+      <% end %>
       <hr />
     <% end %>
   <% else %>
     <!-- Maybe note that this page has been translated -->
-    <% if t('.legal_babble', :locale => @locale) != t('.legal_babble', :locale => :en) %>
-      <h1><%= t '.foreign.title' %></h1>
-      <p>
-        <%= raw t '.foreign.text',
-                    :english_original_link => link_to(t('.foreign.english_link'),
-                                                          :controller => 'site',
-                                                          :action => 'copyright',
-                                                          :copyright_locale => 'en') %>
-      </p>
+    <%= tag.div :lang => "en", :dir => t("html.dir", :locale => "en") do %>
+      <% if t('.legal_babble', :locale => @locale) != t('.legal_babble', :locale => :en) %>
+        <h1><%= t '.foreign.title' %></h1>
+        <p>
+          <%= raw t '.foreign.text',
+                      :english_original_link => link_to(t('.foreign.english_link'),
+                                                            :controller => 'site',
+                                                            :action => 'copyright',
+                                                            :copyright_locale => 'en') %>
+        </p>
+      <% end %>
       <hr />
     <% end %>
   <% end %>
 
-  <h1><%= t ".legal_babble.title_html", :locale => @locale %></h1>
+  <%= tag.h1 :lang => @locale, :dir => t("html.dir", :locale => @locale) do %>
+    <%= t ".legal_babble.title_html", :locale => @locale %>
+  <% end %>
 
 <% end %>
 
-<p><%= t ".legal_babble.intro_1_html", :locale => @locale %></p>
-<p><%= t ".legal_babble.intro_2_html", :locale => @locale %></p>
-<p><%= t ".legal_babble.intro_3_html", :locale => @locale %></p>
+<%= tag.div :lang => @locale, :dir => t("html.dir", :locale => @locale) do %>
+  <p><%= t ".legal_babble.intro_1_html", :locale => @locale %></p>
+  <p><%= t ".legal_babble.intro_2_html", :locale => @locale %></p>
+  <p><%= t ".legal_babble.intro_3_html", :locale => @locale %></p>
 
-<h3><%= t ".legal_babble.credit_title_html", :locale => @locale %></h3>
-<p><%= t ".legal_babble.credit_1_html", :locale => @locale %></p>
-<p><%= t ".legal_babble.credit_2_html", :locale => @locale %></p>
-<p><%= t ".legal_babble.credit_3_html", :locale => @locale %></p>
-<p><%= image_tag("attribution_example.png",
-              :alt => t('.legal_babble.attribution_example.alt'),
-              :border => 0,
-              :title => t('.legal_babble.attribution_example.title')) %>
+  <h3><%= t ".legal_babble.credit_title_html", :locale => @locale %></h3>
+  <p><%= t ".legal_babble.credit_1_html", :locale => @locale %></p>
+  <p><%= t ".legal_babble.credit_2_html", :locale => @locale %></p>
+  <p><%= t ".legal_babble.credit_3_html", :locale => @locale %></p>
+  <p><%= image_tag("attribution_example.png",
+                   :alt => t('.legal_babble.attribution_example.alt'),
+                   :border => 0,
+                   :title => t('.legal_babble.attribution_example.title')) %>
 
-<h3><%= t ".legal_babble.more_title_html", :locale => @locale %></h3>
-<p><%= t ".legal_babble.more_1_html", :locale => @locale %></p>
-<p><%= t ".legal_babble.more_2_html", :locale => @locale %></p>
+  <h3><%= t ".legal_babble.more_title_html", :locale => @locale %></h3>
+  <p><%= t ".legal_babble.more_1_html", :locale => @locale %></p>
+  <p><%= t ".legal_babble.more_2_html", :locale => @locale %></p>
 
-<h3><%= t ".legal_babble.contributors_title_html", :locale => @locale %></h3>
-<p><%= t ".legal_babble.contributors_intro_html", :locale => @locale %></p>
-<ul id="contributors">
-  <li><%= t ".legal_babble.contributors_at_html", :locale => @locale %></li>
-  <li><%= t ".legal_babble.contributors_au_html", :locale => @locale %></li>
-  <li><%= t ".legal_babble.contributors_ca_html", :locale => @locale %></li>
-  <li><%= t ".legal_babble.contributors_fi_html", :locale => @locale %></li>
-  <li><%= t ".legal_babble.contributors_fr_html", :locale => @locale %></li>
-  <li><%= t ".legal_babble.contributors_nl_html", :locale => @locale %></li>
-  <li><%= t ".legal_babble.contributors_nz_html", :locale => @locale %></li>
-  <li><%= t ".legal_babble.contributors_si_html", :locale => @locale %></li>
-  <li><%= t ".legal_babble.contributors_za_html", :locale => @locale %></li>
-  <li><%= t ".legal_babble.contributors_gb_html", :locale => @locale %></li>
-</ul>
-<p><%= t ".legal_babble.contributors_footer_1_html", :locale => @locale %></p>
-<p><%= t ".legal_babble.contributors_footer_2_html", :locale => @locale %></p>
+  <h3><%= t ".legal_babble.contributors_title_html", :locale => @locale %></h3>
+  <p><%= t ".legal_babble.contributors_intro_html", :locale => @locale %></p>
+  <ul id="contributors">
+    <li><%= t ".legal_babble.contributors_at_html", :locale => @locale %></li>
+    <li><%= t ".legal_babble.contributors_au_html", :locale => @locale %></li>
+    <li><%= t ".legal_babble.contributors_ca_html", :locale => @locale %></li>
+    <li><%= t ".legal_babble.contributors_fi_html", :locale => @locale %></li>
+    <li><%= t ".legal_babble.contributors_fr_html", :locale => @locale %></li>
+    <li><%= t ".legal_babble.contributors_nl_html", :locale => @locale %></li>
+    <li><%= t ".legal_babble.contributors_nz_html", :locale => @locale %></li>
+    <li><%= t ".legal_babble.contributors_si_html", :locale => @locale %></li>
+    <li><%= t ".legal_babble.contributors_za_html", :locale => @locale %></li>
+    <li><%= t ".legal_babble.contributors_gb_html", :locale => @locale %></li>
+  </ul>
+  <p><%= t ".legal_babble.contributors_footer_1_html", :locale => @locale %></p>
+  <p><%= t ".legal_babble.contributors_footer_2_html", :locale => @locale %></p>
 
-<h3><%= t ".legal_babble.infringement_title_html", :locale => @locale %></h3>
-<p><%= t ".legal_babble.infringement_1_html", :locale => @locale %></p>
-<p><%= t ".legal_babble.infringement_2_html", :locale => @locale %></p>
+  <h3><%= t ".legal_babble.infringement_title_html", :locale => @locale %></h3>
+  <p><%= t ".legal_babble.infringement_1_html", :locale => @locale %></p>
+  <p><%= t ".legal_babble.infringement_2_html", :locale => @locale %></p>
 
-<h3><%= t ".legal_babble.trademarks_title_html", :locale => @locale %></h3>
-<p><%= t ".legal_babble.trademarks_1_html", :locale => @locale %></p>
+  <h3><%= t ".legal_babble.trademarks_title_html", :locale => @locale %></h3>
+  <p><%= t ".legal_babble.trademarks_1_html", :locale => @locale %></p>
+<% end %>
-- 
2.43.2