From 3114e0905e125d5dbf46bc3a74caf1ba2139fe3e Mon Sep 17 00:00:00 2001
From: Marwin Hochfelsner <50826859+hlfan@users.noreply.github.com>
Date: Wed, 11 Feb 2026 21:01:48 +0000
Subject: [PATCH] Enable some Herb HTML linting rules

---
 .herb.yml                                         | 4 ++++
 app/views/layouts/_banner.html.erb                | 8 ++++----
 app/views/users/changeset_comments/_page.html.erb | 2 +-
 3 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/.herb.yml b/.herb.yml
index cec6f1173..f4c65f790 100644
--- a/.herb.yml
+++ b/.herb.yml
@@ -6,3 +6,7 @@ linter:
       enabled: false
     html-anchor-require-href:
       enabled: false
+    html-no-space-in-tag:
+      enabled: true
+    html-no-title-attribute:
+      enabled: true
diff --git a/app/views/layouts/_banner.html.erb b/app/views/layouts/_banner.html.erb
index 3d2c7f774..f6f76a651 100644
--- a/app/views/layouts/_banner.html.erb
+++ b/app/views/layouts/_banner.html.erb
@@ -1,9 +1,9 @@
 <% unless (banner = next_banner()).nil? %>
   <%= tag.div :id => "banner", :class => "position-relative", :data => { :bs_theme => (banner[:dark] ? "dark" : "light") } do %>
     <%= link_to (image_tag banner[:img], :srcset => banner[:srcset], :alt => banner[:alt], :title => banner[:alt]), banner[:link] %>
-    <button type="button"
-            class="btn-close position-absolute top-0 end-0 m-4 opacity-100 bg-white bg-opacity-50"
-            id="<%= banner_cookie(banner[:id]) %>"
-            aria-label="<%= t("javascripts.close") %>"></button>
+    <%= button_tag "", :type => "button",
+                       :class => "btn-close position-absolute top-0 end-0 m-4 opacity-100 bg-white bg-opacity-50",
+                       :id => banner_cookie(banner[:id]),
+                       :aria => { :label => t("javascripts.close") } %>
   <% end %>
 <% end %>
diff --git a/app/views/users/changeset_comments/_page.html.erb b/app/views/users/changeset_comments/_page.html.erb
index 3aeaad209..688750997 100644
--- a/app/views/users/changeset_comments/_page.html.erb
+++ b/app/views/users/changeset_comments/_page.html.erb
@@ -14,7 +14,7 @@
     <% @comments.each do |comment| -%>
     <tr>
       <td width="25%" class="<%= "text-muted" unless comment.visible? %>"><%= link_to comment.changeset.id, changeset_path(comment.changeset) %></td>
-      <td width="25%" class="<%= "text-muted" unless comment.visible? %>"><span title="<%= l comment.created_at, :format => :friendly %>"><%= time_ago_in_words(comment.created_at, :scope => :"datetime.distance_in_words_ago") %></span></td>
+      <td width="25%" class="<%= "text-muted" unless comment.visible? %>"><%= friendly_date_ago comment.created_at %></td>
       <td width="50%" class="richtext text-break<%= " text-muted" unless comment.visible? %>"><%= comment.body.to_html %></td>
     </tr>
     <% end -%>
-- 
2.39.5