From 42f78e95bfd5cda50889437a1656a180ea108dac Mon Sep 17 00:00:00 2001
From: Anton Khorev <tony29@yandex.ru>
Date: Mon, 7 Jul 2025 21:28:42 +0300
Subject: [PATCH] Make missing node member test similar to create relation
 tests

---
 .../api/relations_controller_test.rb          | 42 ++++++++-----------
 1 file changed, 17 insertions(+), 25 deletions(-)

diff --git a/test/controllers/api/relations_controller_test.rb b/test/controllers/api/relations_controller_test.rb
index 15ffc026f..098e0a4bd 100644
--- a/test/controllers/api/relations_controller_test.rb
+++ b/test/controllers/api/relations_controller_test.rb
@@ -401,6 +401,23 @@ module Api
       end
     end
 
+    def test_create_with_missing_node_member
+      with_unchanging_request do |headers, changeset|
+        osm = <<~OSM
+          <osm>
+            <relation changeset='#{changeset.id}'>
+              <member type='node' ref='0'/>
+            </relation>
+          </osm>
+        OSM
+
+        post api_relations_path, :params => osm, :headers => headers
+
+        assert_response :precondition_failed, "relation upload with invalid node did not return 'precondition failed'"
+        assert_equal "Precondition failed: Relation with id  cannot be saved due to Node with id 0", @response.body
+      end
+    end
+
     def test_create_and_show
       user = create(:user)
       changeset = create(:changeset, :user => user)
@@ -442,31 +459,6 @@ module Api
       assert_response :bad_request
     end
 
-    # -------------------------------------
-    # Test creating some invalid relations.
-    # -------------------------------------
-
-    def test_create_invalid
-      user = create(:user)
-      changeset = create(:changeset, :user => user)
-
-      auth_header = bearer_authorization_header user
-
-      # create a relation with non-existing node as member
-      xml = <<~OSM
-        <osm>
-          <relation changeset='#{changeset.id}'>
-            <member type='node' ref='0'/>
-          </relation>
-        </osm>
-      OSM
-      post api_relations_path, :params => xml, :headers => auth_header
-      # expect failure
-      assert_response :precondition_failed,
-                      "relation upload with invalid node did not return 'precondition failed'"
-      assert_equal "Precondition failed: Relation with id  cannot be saved due to Node with id 0", @response.body
-    end
-
     # -------------------------------------
     # Test creating a relation, with some invalid XML
     # -------------------------------------
-- 
2.39.5