From 4e0c5f5fcb8e9d71a116e726bcd132d884a8e954 Mon Sep 17 00:00:00 2001 From: Tom Hughes Date: Tue, 10 Jan 2023 20:58:10 +0000 Subject: [PATCH 1/1] Make distances in directions translatable Fixes #3888 --- app/assets/javascripts/index/directions.js | 14 +++++++++----- config/locales/en.yml | 2 ++ 2 files changed, 11 insertions(+), 5 deletions(-) diff --git a/app/assets/javascripts/index/directions.js b/app/assets/javascripts/index/directions.js index 75c647802..7bd0891a3 100644 --- a/app/assets/javascripts/index/directions.js +++ b/app/assets/javascripts/index/directions.js @@ -169,14 +169,18 @@ OSM.Directions = function (map) { function formatDistance(m) { if (m < 1000) { - return Math.round(m) + "m"; + return I18n.t("javascripts.directions.distance_m", { distance: Math.round(m) }); } else if (m < 10000) { - return (m / 1000.0).toFixed(1) + "km"; + return I18n.t("javascripts.directions.distance_km", { distance: (m / 1000.0).toFixed(1) }); } else { - return Math.round(m / 1000) + "km"; + return I18n.t("javascripts.directions.distance_km", { distance: Math.round(m / 1000) }); } } + function formatHeight(m) { + return I18n.t("javascripts.directions.distance_m", { distance: Math.round(m) }); + } + function formatTime(s) { var m = Math.round(s / 60); var h = Math.floor(m / 60); @@ -260,8 +264,8 @@ OSM.Directions = function (map) { if (typeof route.ascend !== "undefined" && typeof route.descend !== "undefined") { distanceText.append( $("
"), - I18n.t("javascripts.directions.ascend") + ": " + Math.round(route.ascend) + "m. " + - I18n.t("javascripts.directions.descend") + ": " + Math.round(route.descend) + "m."); + I18n.t("javascripts.directions.ascend") + ": " + formatHeight(route.ascend) + ". " + + I18n.t("javascripts.directions.descend") + ": " + formatHeight(route.descend) + "."); } var turnByTurnTable = $(""); diff --git a/config/locales/en.yml b/config/locales/en.yml index 6b65a5cf4..c3a752e4a 100644 --- a/config/locales/en.yml +++ b/config/locales/en.yml @@ -2949,6 +2949,8 @@ en: descend: "Descend" directions: "Directions" distance: "Distance" + distance_m: "%{distance}m" + distance_km: "%{distance}km" errors: no_route: "Couldn't find a route between those two places." no_place: "Sorry - couldn't locate '%{place}'." -- 2.45.1