From 57bf5e0b66cbada5c290945024b48e62aab10625 Mon Sep 17 00:00:00 2001 From: Anton Khorev Date: Wed, 30 Apr 2025 06:48:24 +0300 Subject: [PATCH] Split api changeset close tests for missing changesets --- .../api/changesets/closes_controller_test.rb | 33 ++++++++----------- 1 file changed, 14 insertions(+), 19 deletions(-) diff --git a/test/controllers/api/changesets/closes_controller_test.rb b/test/controllers/api/changesets/closes_controller_test.rb index 790f9b67e..350762550 100644 --- a/test/controllers/api/changesets/closes_controller_test.rb +++ b/test/controllers/api/changesets/closes_controller_test.rb @@ -16,6 +16,20 @@ module Api end end + def test_update_missing_changeset_when_unauthorized + put api_changeset_close_path(999111) + + assert_response :unauthorized + end + + def test_update_missing_changeset_by_regular_user + auth_header = bearer_authorization_header + + put api_changeset_close_path(999111), :headers => auth_header + + assert_response :not_found + end + def test_update_when_unauthorized changeset = create(:changeset) @@ -75,25 +89,6 @@ module Api assert_response :not_found assert_template "rescues/routing_error" end - - ## - # check that you can't close a changeset that isn't found - def test_update_not_found - cs_ids = [0, "123"] - - # First try to do it with no auth - cs_ids.each do |id| - put api_changeset_close_path(id) - assert_response :unauthorized, "Shouldn't be able close the non-existant changeset #{id}, when not authorized" - end - - # Now try with auth - auth_header = bearer_authorization_header - cs_ids.each do |id| - put api_changeset_close_path(id), :headers => auth_header - assert_response :not_found, "The changeset #{id} doesn't exist, so can't be closed" - end - end end end end -- 2.39.5