From 586d5da9926bc491c053cb5a939d67156b44688c Mon Sep 17 00:00:00 2001
From: Anton Khorev <tony29@yandex.ru>
Date: Sun, 6 Jul 2025 21:52:01 +0300
Subject: [PATCH] Remove unnecessary tags from api elements test xml

---
 .../api/relations_controller_test.rb          | 16 +++++++--------
 test/controllers/api/ways_controller_test.rb  | 20 +++++++++----------
 2 files changed, 18 insertions(+), 18 deletions(-)

diff --git a/test/controllers/api/relations_controller_test.rb b/test/controllers/api/relations_controller_test.rb
index e2f6ca1c2..2dfcd36a4 100644
--- a/test/controllers/api/relations_controller_test.rb
+++ b/test/controllers/api/relations_controller_test.rb
@@ -401,7 +401,7 @@ module Api
 
       # create a relation with non-existing node as member
       xml = "<osm><relation changeset='#{changeset.id}'>" \
-            "<member type='node' ref='0'/><tag k='test' v='yes' />" \
+            "<member type='node' ref='0'/>" \
             "</relation></osm>"
       post api_relations_path, :params => xml, :headers => auth_header
       # expect failure
@@ -423,7 +423,7 @@ module Api
       # create some xml that should return an error
       xml = "<osm><relation changeset='#{changeset.id}'>" \
             "<member type='type' ref='#{node.id}' role=''/>" \
-            "<tag k='tester' v='yep'/></relation></osm>"
+            "</relation></osm>"
       post api_relations_path, :params => xml, :headers => auth_header
       # expect failure
       assert_response :bad_request
@@ -589,7 +589,7 @@ module Api
       xml = "<osm><relation changeset='#{changeset.id}'>" \
             "<member  ref='#{node1.id}' type='node' role='some'/>" \
             "<member  ref='#{node2.id}' type='node' role='some'/>" \
-            "<tag k='test' v='yes' /></relation></osm>"
+            "</relation></osm>"
       post api_relations_path, :params => xml, :headers => auth_header
       assert_response :success, "relation create did not return success status"
 
@@ -600,7 +600,7 @@ module Api
       xml = "<osm><relation id='#{relationid}' version='1' changeset='#{changeset.id}'>" \
             "<member  ref='#{node2.id}' type='node' role='some'/>" \
             "<member  ref='#{node1.id}' type='node' role='some'/>" \
-            "<tag k='test' v='yes' /></relation></osm>"
+            "</relation></osm>"
       put api_relation_path(relationid), :params => xml, :headers => auth_header
       assert_response :too_many_requests, "relation update did not hit rate limit"
 
@@ -613,7 +613,7 @@ module Api
       xml = "<osm><relation changeset='#{changeset.id}'>" \
             "<member  ref='#{node1.id}' type='node' role='some'/>" \
             "<member  ref='#{node2.id}' type='node' role='some'/>" \
-            "<tag k='test' v='yes' /></relation></osm>"
+            "</relation></osm>"
       post api_relations_path, :params => xml, :headers => auth_header
       assert_response :too_many_requests, "relation create did not hit rate limit"
     end
@@ -649,7 +649,7 @@ module Api
       xml = "<osm><relation changeset='#{changeset.id}'>" \
             "<member  ref='#{node1.id}' type='node' role='some'/>" \
             "<member  ref='#{node2.id}' type='node' role='some'/>" \
-            "<tag k='test' v='yes' /></relation></osm>"
+            "</relation></osm>"
       post api_relations_path, :params => xml, :headers => auth_header
       assert_response :success, "relation create did not return success status"
 
@@ -660,7 +660,7 @@ module Api
       xml = "<osm><relation id='#{relationid}' version='1' changeset='#{changeset.id}'>" \
             "<member  ref='#{node2.id}' type='node' role='some'/>" \
             "<member  ref='#{node1.id}' type='node' role='some'/>" \
-            "<tag k='test' v='yes' /></relation></osm>"
+            "</relation></osm>"
       put api_relation_path(relationid), :params => xml, :headers => auth_header
       assert_response :too_many_requests, "relation update did not hit rate limit"
 
@@ -673,7 +673,7 @@ module Api
       xml = "<osm><relation changeset='#{changeset.id}'>" \
             "<member  ref='#{node1.id}' type='node' role='some'/>" \
             "<member  ref='#{node2.id}' type='node' role='some'/>" \
-            "<tag k='test' v='yes' /></relation></osm>"
+            "</relation></osm>"
       post api_relations_path, :params => xml, :headers => auth_header
       assert_response :too_many_requests, "relation create did not hit rate limit"
     end
diff --git a/test/controllers/api/ways_controller_test.rb b/test/controllers/api/ways_controller_test.rb
index 50077f09c..2d0a76de6 100644
--- a/test/controllers/api/ways_controller_test.rb
+++ b/test/controllers/api/ways_controller_test.rb
@@ -273,7 +273,7 @@ module Api
       # use the first user's open changeset
       # create a way with non-existing node
       xml = "<osm><way changeset='#{private_open_changeset.id}'>" \
-            "<nd ref='0'/><tag k='test' v='yes' /></way></osm>"
+            "<nd ref='0'/></way></osm>"
       post api_ways_path, :params => xml, :headers => auth_header
       # expect failure
       assert_response :forbidden,
@@ -281,7 +281,7 @@ module Api
 
       # create a way with no nodes
       xml = "<osm><way changeset='#{private_open_changeset.id}'>" \
-            "<tag k='test' v='yes' /></way></osm>"
+            "</way></osm>"
       post api_ways_path, :params => xml, :headers => auth_header
       # expect failure
       assert_response :forbidden,
@@ -301,7 +301,7 @@ module Api
       # use the first user's open changeset
       # create a way with non-existing node
       xml = "<osm><way changeset='#{open_changeset.id}'>" \
-            "<nd ref='0'/><tag k='test' v='yes' /></way></osm>"
+            "<nd ref='0'/></way></osm>"
       post api_ways_path, :params => xml, :headers => auth_header
       # expect failure
       assert_response :precondition_failed,
@@ -310,7 +310,7 @@ module Api
 
       # create a way with no nodes
       xml = "<osm><way changeset='#{open_changeset.id}'>" \
-            "<tag k='test' v='yes' /></way></osm>"
+            "</way></osm>"
       post api_ways_path, :params => xml, :headers => auth_header
       # expect failure
       assert_response :precondition_failed,
@@ -799,7 +799,7 @@ module Api
       # try creating a way
       xml = "<osm><way changeset='#{changeset.id}'>" \
             "<nd ref='#{node1.id}'/><nd ref='#{node2.id}'/>" \
-            "<tag k='test' v='yes' /></way></osm>"
+            "</way></osm>"
       post api_ways_path, :params => xml, :headers => auth_header
       assert_response :success, "way create did not return success status"
 
@@ -809,7 +809,7 @@ module Api
       # try updating the way, which should be rate limited
       xml = "<osm><way id='#{wayid}' version='1' changeset='#{changeset.id}'>" \
             "<nd ref='#{node2.id}'/><nd ref='#{node1.id}'/>" \
-            "<tag k='test' v='yes' /></way></osm>"
+            "</way></osm>"
       put api_way_path(wayid), :params => xml, :headers => auth_header
       assert_response :too_many_requests, "way update did not hit rate limit"
 
@@ -821,7 +821,7 @@ module Api
       # try creating a way, which should be rate limited
       xml = "<osm><way changeset='#{changeset.id}'>" \
             "<nd ref='#{node1.id}'/><nd ref='#{node2.id}'/>" \
-            "<tag k='test' v='yes' /></way></osm>"
+            "</way></osm>"
       post api_ways_path, :params => xml, :headers => auth_header
       assert_response :too_many_requests, "way create did not hit rate limit"
     end
@@ -856,7 +856,7 @@ module Api
       # try creating a way
       xml = "<osm><way changeset='#{changeset.id}'>" \
             "<nd ref='#{node1.id}'/><nd ref='#{node2.id}'/>" \
-            "<tag k='test' v='yes' /></way></osm>"
+            "</way></osm>"
       post api_ways_path, :params => xml, :headers => auth_header
       assert_response :success, "way create did not return success status"
 
@@ -866,7 +866,7 @@ module Api
       # try updating the way, which should be rate limited
       xml = "<osm><way id='#{wayid}' version='1' changeset='#{changeset.id}'>" \
             "<nd ref='#{node2.id}'/><nd ref='#{node1.id}'/>" \
-            "<tag k='test' v='yes' /></way></osm>"
+            "</way></osm>"
       put api_way_path(wayid), :params => xml, :headers => auth_header
       assert_response :too_many_requests, "way update did not hit rate limit"
 
@@ -878,7 +878,7 @@ module Api
       # try creating a way, which should be rate limited
       xml = "<osm><way changeset='#{changeset.id}'>" \
             "<nd ref='#{node1.id}'/><nd ref='#{node2.id}'/>" \
-            "<tag k='test' v='yes' /></way></osm>"
+            "</way></osm>"
       post api_ways_path, :params => xml, :headers => auth_header
       assert_response :too_many_requests, "way create did not hit rate limit"
     end
-- 
2.39.5